feat(rundler): add support for Rundler v0.3.0 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
approved these changes
Jul 9, 2024
|
@jxom when you get a chance can you take a look at this? |
jxom
reviewed
Jul 23, 2024
| * Use the submit URL for transaction status checks. | ||
| * @default false | ||
| */ | ||
| use_submit_for_status?: boolean |
There was a problem hiding this comment.
Suggested change
| use_submit_for_status?: boolean | |
| useSubmitForStatus?: boolean | undefined |
These should automatically be converted to snake_case at runtime.
jxom
reviewed
Jul 23, 2024
| */ | ||
| sender?: 'raw' | 'conditional' | 'flashbots' | 'polygonBloxroute' | ||
| dropped_status_unsupported?: boolean |
There was a problem hiding this comment.
Suggested change
| dropped_status_unsupported?: boolean | |
| droppedStatusUnsupported?: boolean | undefined |
jxom
reviewed
Jul 23, 2024
| * options: raw, conditional, flashbots, polygon_bloxroute | ||
| * options: raw, flashbots, polygon_bloxroute | ||
| */ | ||
| sender?: 'raw' | 'flashbots' | 'polygonBloxroute' |
There was a problem hiding this comment.
Suggested change
| sender?: 'raw' | 'flashbots' | 'polygonBloxroute' | |
| sender?: 'raw' | 'flashbots' | 'polygonBloxroute' | undefined |
jxom
reviewed
Jul 23, 2024
| */ | ||
| maxFeeIncreases?: number | ||
| maxCancellationFeeIncreases?: number |
There was a problem hiding this comment.
Suggested change
| maxCancellationFeeIncreases?: number | |
| maxCancellationFeeIncreases?: number | undefined |
jxom
reviewed
Jul 23, 2024
| * The maximum number of blocks to spend in a replacement underpriced state before issuing a transaction cancellation. | ||
| * @default 20 | ||
| */ | ||
| maxReplacementUnderpricedBlocks?: number |
There was a problem hiding this comment.
Suggested change
| maxReplacementUnderpricedBlocks?: number | |
| maxReplacementUnderpricedBlocks?: number | undefined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the CLI arguments in the latest Rundler version v0.3.0