Added building and access via webapp to the Storybook design inventory #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no detail in this issue, on how this is going to be used, so I'm shooting in the dark a bit. npm start is for development, but I added the capability there anyways npm build and npm prod, are (I think) what the production servers use, so I also added the capability to those scripts. It looks like anyone who navigates to https://wevote.us/storybook will be able to modify the statically built copy of the inventory, but those changes do not seem to effect the master copy (wherever that is stored), since when you regenerate the static files, those local changes are overwritten. The downside is that those local changes seem to persist between sessions (between different users), so accidental changes could be confusing, and purposeful changes would be lost. I think there is no harm in making this live, but it will probably need more analysis re: what we are using it for, and how it will be used. And do we need to restrict access? Implements https://wevoteusa.atlassian.net/browse/WV-206
There is no detail in this issue, on how this is going to be used, so I'm shooting in the dark a bit. npm start is for development, but I added the capability there anyways npm build and npm prod, are (I think) what the production servers use, so I also added the capability to those scripts. It looks like anyone who navigates to https://wevote.us/storybook will be able to modify the statically built copy of the inventory, but those changes do not seem to effect the master copy (wherever that is stored), since when you regenerate the static files, those local changes are overwritten. The downside is that those local changes seem to persist between sessions (between different users), so accidental changes could be confusing, and purposeful changes would be lost. I think there is no harm in making this live, but it will probably need more analysis re: what we are using it for, and how it will be used. And do we need to restrict access? Implements https://wevoteusa.atlassian.net/browse/WV-206
|
👍 |
|
The local storage was on the url. as passed parameters, so no problem with local changes effecting the actual setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no detail in this issue, on how this is going to be used, so I'm shooting in the dark a bit.
npm startis for development, but I added the capability there anyways.npm buildandnpm prod, are (I think) what the production servers use, so I also added the capability to those scripts.It looks like anyone who navigates to https://wevote.us/storybook will be able to modify the statically built copy of the inventory, but those changes do not seem to effect the master copy (wherever that is stored), since when you regenerate the static files, those local changes are overwritten. The downside is that those local changes seem to persist between sessions (between different users), so accidental changes could be confusing, and purposeful changes would be lost.
I think there is no harm in making this live, but it will probably need more analysis re: what we are using it for, and how it will be used. And do we need to restrict access?
Implements https://wevoteusa.atlassian.net/browse/WV-206