WV-553 Analytics Data Capture: Candidate/Politician landing page loads [CHANGES NEEDED] #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleMcGrew
changed the title
…ce, as per Dale's suggestions
…update its value by calling setState()
…er and politician object
…, politician, pageDetails
Zubin-glitch
changed the title
Zubin-glitch
changed the title
DaleMcGrew
changed the title
DaleMcGrew
requested changes
Mar 1, 2025
| @@ -164,15 +167,24 @@ class PoliticianDetailsPage extends Component { | |||
| } | |||
|
|
|||
| componentDidMount () { | |||
| // console.log('PoliticianDetailsPage componentDidMount'); | |||
| console.log('PoliticianDetailsPage componentDidMount'); | |||
| // console.log('onPoliticianStoreChange politicianSEOFriendlyPathFromUrl: ', politicianSEOFriendlyPathFromUrl, ', politicianWeVoteIdFromParams: ', politicianWeVoteIdFromParams); | ||
| console.log('onPoliticianStoreChange politicianSEOFriendlyPathFromUrl: ', politicianSEOFriendlyPathFromUrl, ', politicianWeVoteIdFromParams: ', politicianWeVoteIdFromParams); | ||
| // Experimental TagManager add (WORKS!) | ||
| const politician = PoliticianStore.getPoliticianBySEOFriendlyPath(politicianSEOFriendlyPathFromUrl); |
There was a problem hiding this comment.
Move this to componentDidUpdate, but implement a "gate" so that it only calls Google Tag Manager once.
| @@ -127,6 +127,7 @@ | |||
| "d3-zoom": "^3.0.0", | |||
| "flux": "~4.0.1", | |||
| "fs-extra": "^10.0.0", | |||
| "fsevents": "^2.3.3", | |||
There was a problem hiding this comment.
Hi @Zubin-glitch we can't check in fsevents as a requirement because it only works on Mac computers. Please back out this change, and the package-lock.json file.
| @@ -28,7 +28,7 @@ class PoliticianRetrieveController extends Component { | |||
| politicianWeVoteId, | |||
| } = this.props; | |||
| if (politicianWeVoteId !== previousPoliticianWeVoteId) { | |||
| // console.log('PoliticianRetrieveController componentDidUpdate politicianWeVoteId has changed'); | |||
| console.log('PoliticianRetrieveController componentDidUpdate politicianWeVoteId has changed'); | |||
There was a problem hiding this comment.
I ask that console logs be commented out with checkins, so we can keep the production version console empty of most WeVote logging.
| @@ -136,6 +137,7 @@ class PoliticianStore extends ReduceStore { | |||
| return positionsAboutPolitician[orgWeVoteId] || []; | |||
| } | |||
|
|
|||
| // Ask Dale about why this is needed - Zubin | |||
There was a problem hiding this comment.
I've added this getVoterCanEditThisPolitician stub because we are planning to make it so the staff of politicians can update Politician information on WeVote, and the staff would be signed in with a WeVote voter account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
It adds a data layer to the Politician's landing/loading page
Changes included this pull request?
Added TagManager.dataLayer(), capturing the following: voterWeVoteId, politicianWeVoteId, politicianName and politicianState (state code).
Google Tag Manager captures information after a Politician's name (hyperlink) is clicked on their display card opening their page.