WV-986/WBV-987 Add Data Layer To "Show More" buttons on '"Fine Print" and "We Vote helps you" [CHANGES NEEDED] #4265
Conversation
DaleMcGrew
changed the title
| // console.log("Show More clicked (tracked):", showMoreId); | ||
| // const eventName = showMoreCustomText || 'show more'; | ||
| const dataLayerObject = { | ||
| event: 'Show More Button Clicked', |
There was a problem hiding this comment.
I believe we want "event" to be a camelCase event name we can listen for in GTM, instead of a sentence.
| // const eventName = showMoreCustomText || 'show more'; | ||
| const dataLayerObject = { | ||
| event: 'Show More Button Clicked', | ||
| element_id: showMoreId, |
There was a problem hiding this comment.
Let's add "element_id" to the pageDetails dictionary. Please also make it camelCase.
| const dataLayerObject = { | ||
| event: 'Show More Button Clicked', | ||
| element_id: showMoreId, | ||
| source:{ |
There was a problem hiding this comment.
Please convert "source" to "pageDetails".
| pageType: "homepage", | ||
| pathName: window.location.pathname, | ||
| }, | ||
| user:{ |
There was a problem hiding this comment.
Please change "user" to "userDetails".
| // console.log("dataLayerObject:", dataLayerObject) | ||
| TagManager.dataLayer({ dataLayer: dataLayerObject }); | ||
| } else if (trackInGTM && showMoreButtonWasClicked){ | ||
| console.log("Show Less clicked (not tracked):", showMoreId); |
There was a problem hiding this comment.
Only indent by 2 spaces instead of 3. I think we should track "show less" clicks.
|
|
||
|
|
||
| class ShowMoreButtons extends React.Component { | ||
| handleClick=()=>{ |
There was a problem hiding this comment.
Please change the generic function name handleClick to a function name that tells other programmers what this function is doing. For example sendDataToGTMAndNotifyParent.
Add Google Tag Manager data layer to two "Show More" instances: "fine print" and "we vote helps you.
Specific logic changes include passing props from ReadyIntroduction.jsx and ReadyFinePrint.jsx components to create the instances where GTM fires. Adding "trackInGTM={true}" down to other Show more instances will create data layers in those as well if future needs require.