WV-??? Add Source Object into GTM logic SearchBar2024.jsx [CHANGES NEEDED] #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleMcGrew
requested changes
Mar 1, 2025
| @@ -73,6 +73,11 @@ class SearchBar2024 extends Component { | |||
| const dataLayerObject = { | |||
| event: 'searchKeyword', | |||
| searchKeyword: searchString, | |||
| source:{ | |||
There was a problem hiding this comment.
Update to source to pageDetails.
| pageName: window.location.href, | ||
| pageType: "challenge", | ||
| pathName: window.location.pathname, | ||
| }, | ||
| user:{ |
| @@ -73,6 +73,11 @@ class SearchBar2024 extends Component { | |||
| const dataLayerObject = { | |||
| event: 'searchKeyword', | |||
| searchKeyword: searchString, | |||
| source:{ | |||
| pageName: window.location.href, | |||
| pageType: "challenge", | |||
There was a problem hiding this comment.
We want the pageName & pageType to come from the parent component that calls searchBar20204, but instead of adding props we need to pass from the parent, I think another approach will be more maintainable. Please create a function in /js/utils/calculateGTMPageType.js which takes in the pathName, and returns one of our pageTypes:
ballot, politician, candidate, donation, homepage, ballot, account, challenge, issue
...and then an even more specific pageName. Feel free to reach out with questions!
DaleMcGrew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SearchBar2024.jsx GTM logic to include updated 'source' object.