Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Match ECMA‑262 order of the constructor property #934

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Normative: Match ECMA‑262 order of the constructor property #934

wants to merge 1 commit into from
+3 −6

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Oct 29, 2020 •
edited by pr-preview bot
Loading

In ECMA‑262, the "constructor" property is the first property that’s added to the prototype object after its creation.

This matches V8’s implementation of built‑in objects, including ones implemented using WebIDL.

Preview | Diff

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Mar 7, 2022, 7:34 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@TimothyGu
Copy link
Member

Are there tests available for this?

@TimothyGu TimothyGu added the needs tests Moving the issue forward requires someone to write tests label Jun 30, 2021
@ExE-Boss ExE-Boss marked this pull request as draft August 12, 2021 09:24
@ExE-Boss ExE-Boss force-pushed the normative/ecma262/match-constructor-property-order branch from 7b3fafb to b372e76 Compare March 7, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TimothyGu TimothyGu

Labels
needs tests Moving the issue forward requires someone to write tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExE-Boss @TimothyGu