fix linter warnings

cmd/whawty-auth/hooks.go

@@ -76,7 +76,7 @@ func runHook(executeable, store string) {
 			select {
 			case <-t.C:
 				wl.Printf("Hooks: killing long running hook '%s'", executeable)
-				cmd.Process.Kill()
+				cmd.Process.Kill() //nolint:errcheck
 			case err := <-exited:
 				if err != nil {
 					wl.Printf("Hooks: '%s': %v", executeable, err)

cmd/whawty-auth/main.go

@@ -82,7 +82,7 @@ func askPass() (string, error) {
 func cmdInit(c *cli.Context) error {
 	username := c.Args().First()
 	if username == "" {
-		cli.ShowCommandHelp(c, "init")
+		cli.ShowCommandHelp(c, "init") //nolint:errcheck
 		return cli.NewExitError("", 0)
 	}
 
@@ -147,7 +147,7 @@ func cmdAdd(c *cli.Context) error {
 
 	username := c.Args().First()
 	if username == "" {
-		cli.ShowCommandHelp(c, "add")
+		cli.ShowCommandHelp(c, "add") //nolint:errcheck
 		return cli.NewExitError("", 0)
 	}
 
@@ -177,7 +177,7 @@ func cmdRemove(c *cli.Context) error {
 
 	username := c.Args().First()
 	if username == "" {
-		cli.ShowCommandHelp(c, "remove")
+		cli.ShowCommandHelp(c, "remove") //nolint:errcheck
 		return cli.NewExitError("", 0)
 	}
 
@@ -195,7 +195,7 @@ func cmdUpdate(c *cli.Context) error {
 
 	username := c.Args().First()
 	if username == "" {
-		cli.ShowCommandHelp(c, "update")
+		cli.ShowCommandHelp(c, "update") //nolint:errcheck
 		return cli.NewExitError("", 0)
 	}
 
@@ -689,5 +689,5 @@ func main() {
 	}
 
 	wdl.Printf("calling app.Run()")
-	app.Run(os.Args)
+	app.Run(os.Args) //nolint:errcheck
 }

cmd/whawty-auth/store.go

@@ -243,9 +243,8 @@ func (s *store) listFull() (result listFullResult) {
 }
 
 func (s *store) authenticate(username, password string) (result authenticateResult) {
-	var upgradeable bool
-	result.ok, result.isAdmin, upgradeable, result.lastChanged, result.err = s.dir.Authenticate(username, password)
-	if result.ok && upgradeable && s.upgradeChan != nil {
+	result.ok, result.isAdmin, result.upgradeable, result.lastChanged, result.err = s.dir.Authenticate(username, password)
+	if result.ok && result.upgradeable && s.upgradeChan != nil {
 		s.upgradeChan <- updateRequest{username: username, password: password}
 	}
 	return

cmd/whawty-auth/web_api.go

@@ -494,8 +494,8 @@ func (ln tcpKeepAliveListener) Accept() (c net.Conn, err error) {
 	if err != nil {
 		return
 	}
-	tc.SetKeepAlive(true)
-	tc.SetKeepAlivePeriod(3 * time.Minute)
+	tc.SetKeepAlive(true)                  //nolint:errcheck
+	tc.SetKeepAlivePeriod(3 * time.Minute) //nolint:errcheck
 	return tc, nil
 }
 

sasl/sasl.go

@@ -89,7 +89,7 @@ func (s *Server) handleConnection(conn net.Conn) {
 		}
 	}
 
-	resp.Encode(conn) // silently drop error...
+	resp.Encode(conn) //nolint:errcheck
 }
 
 // Run actually runs the server. In calls Accept() on the server socket and