Switch ESLint configuration to more closely match Signal-Desktop

.prettierrc.js

@@ -1,4 +1,4 @@
 module.exports = {
   singleQuote: true,
-  trailingComma: 'all',
+  trailingComma: 'es5',
 };

node/.eslintrc.js

@@ -5,15 +5,23 @@ module.exports = {
 
   parserOptions: {
     project: './tsconfig.json',
+    ecmaVersion: 2018,
+    sourceType: 'module',
   },
 
   settings: {
     'import/core-modules': ['electron'],
   },
 
-  plugins: ['header', 'mocha', 'more', '@typescript-eslint'],
+  plugins: ['header', 'import', 'mocha', 'more', '@typescript-eslint'],
 
-  extends: ['airbnb-typescript/base'],
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:import/errors',
+    'plugin:import/warnings',
+    'plugin:import/typescript',
+  ],
 
   rules: {
     'header/header': [
@@ -27,6 +35,17 @@ module.exports = {
       ],
     ],
 
+    'comma-dangle': [
+      'error',
+      {
+        arrays: 'always-multiline',
+        objects: 'always-multiline',
+        imports: 'always-multiline',
+        exports: 'always-multiline',
+        functions: 'never',
+      },
+    ],
+
     // prevents us from accidentally checking in exclusive tests (`.only`):
     'mocha/no-exclusive-tests': 'error',
 
@@ -39,6 +58,9 @@ module.exports = {
     // useful for unused or internal fields
     'no-underscore-dangle': 'off',
 
+    // useful for unused parameters
+    '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+
     // though we have a logger, we still remap console to log to disk
     'no-console': 'error',
 
@@ -51,23 +73,11 @@ module.exports = {
       { avoidEscape: true, allowTemplateLiterals: false },
     ],
 
+    // We prefer named exports
+    'import/prefer-default-export': 'off',
+
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/consistent-type-assertions': 'error',
-
-    // Prettier overrides:
-    'arrow-parens': 'off',
-    'function-paren-newline': 'off',
-    'max-len': [
-      'error',
-      {
-        // Prettier generally limits line length to 80 but sometimes goes over.
-        // The `max-len` plugin doesn’t let us omit `code` so we set it to a
-        // high value as a buffer to let Prettier control the line length:
-        code: 999,
-        // We still want to limit comments as before:
-        comments: 90,
-        ignoreUrls: true,
-      },
-    ],
+    '@typescript-eslint/explicit-module-boundary-types': 'error',
   },
 };

node/index.ts

@@ -3,10 +3,9 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 //
 
+import bindings = require('bindings'); // eslint-disable-line @typescript-eslint/no-require-imports
 import * as SignalClient from './libsignal_client';
-import bindings = require('bindings'); // eslint-disable-line import/order, @typescript-eslint/no-require-imports
 
-// eslint-disable-next-line import/prefer-default-export
 export const { PrivateKey } = bindings(
-  'libsignal_client',
+  'libsignal_client'
 ) as typeof SignalClient;

node/test/PublicAPITest.ts

@@ -14,7 +14,7 @@ describe('SignalClient', () => {
     assert(a.serialize().equals(a.serialize()), 'repeatable');
     assert(
       !a.serialize().equals(b.serialize()),
-      'different for different keys',
+      'different for different keys'
     );
   });
 });

package.json

@@ -28,16 +28,11 @@
     "electron-build-env": "^0.2.0",
     "electron-mocha": "8.1.1",
     "eslint": "^7.12.1",
-    "eslint-config-airbnb-base": "^14.2.0",
-    "eslint-config-airbnb-typescript": "^12.0.0",
     "eslint-config-prettier": "6.15.0",
     "eslint-plugin-header": "^3.1.0",
     "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jsx-a11y": "^6.4.1",
     "eslint-plugin-mocha": "^8.0.0",
     "eslint-plugin-more": "^1.0.0",
-    "eslint-plugin-react": "^7.21.5",
-    "eslint-plugin-react-hooks": "^4.2.0",
     "mocha": "7.1.1",
     "node-gyp": "^7.1.2",
     "prettier": "1.19.1",