Update device capabilities #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I suppose you've tried it with either |
|
I tried it with Flare. Worked for me. |
|
Can we at least document what this new capability is? Just advertising that we're capable of handling it might get us into more trouble than not being able to link. |
|
I couldn't figure it out from the source of SD 😢 |
|
Signal Server code: STORAGE_SERVICE_RECORD_KEY_ROTATION("ssre2", AccountCapabilityMode.ALL_DEVICES, true, true);Signal Android: @JsonProperty("ssre2") val storageServiceEncryptionV2: BooleanI assume it pertains to backups. |
This fixes a 409 error received when linking devices. Fixes whisperfish#352.
Schmiddiii
force-pushed
the
fix-409-linking
branch
from
68488b2 to
b56ea88
Compare
|
I added a little comment to the field, referencing both the Signal Android and Signal Server source code you mentioned. |
gferon
approved these changes
Jan 28, 2025
|
Can this be merged or is there anything else I should do in this PR? |
Schmiddiii
added a commit
to Schmiddiii/presage
that referenced
this pull request
Jan 30, 2025
Contains an important fix for linking devices Fixes whisperfish/libsignal-service-rs#352 via upstream PR whisperfish/libsignal-service-rs#353.
gferon
pushed a commit
to whisperfish/presage
that referenced
this pull request
Jan 30, 2025
Contains an important fix for linking devices Fixes whisperfish/libsignal-service-rs#352 via upstream PR whisperfish/libsignal-service-rs#353.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a 409 error received when linking devices. Fixes #352.