Skip to content

Merge pull request #354 from whisperfish/profile-demo-code #1092

Merge pull request #354 from whisperfish/profile-demo-code

Merge pull request #354 from whisperfish/profile-demo-code #1092

GitHub Actions / clippy succeeded Feb 8, 2025 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.84.1 (e71f9a9a9 2025-01-27)
  • cargo 1.84.1 (66221abde 2024-11-19)
  • clippy 0.1.84 (e71f9a9a98 2025-01-27)

Annotations

Check warning on line 339 in src/sender.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` is redundant

warning: this `map_or` is redundant
   --> src/sender.rs:336:13
    |
336 | /             self.protocol_store
337 | |                 .get_sub_device_sessions(&self.local_aci.into())
338 | |                 .await
339 | |                 .map_or(false, |s| !s.is_empty())
    | |_________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
help: use is_ok_and instead
    |
336 ~             self.protocol_store
337 +                 .get_sub_device_sessions(&self.local_aci.into())
338 +                 .await.is_ok_and(|s| !s.is_empty())
    |

Check warning on line 125 in src/push_service/registration.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/push_service/registration.rs:125:46
    |
125 |     pub async fn submit_registration_request<'a>(
    |                                              ^^
126 |         &mut self,
127 |         registration_method: RegistrationMethod<'a>,
    |                                                 ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

Check warning on line 10 in src/digeststream.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'r

warning: the following explicit lifetimes could be elided: 'r
  --> src/digeststream.rs:10:6
   |
10 | impl<'r, R: Read + Seek> Read for DigestingReader<'r, R> {
   |      ^^                                           ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
10 - impl<'r, R: Read + Seek> Read for DigestingReader<'r, R> {
10 + impl<R: Read + Seek> Read for DigestingReader<'_, R> {
   |