fix(pytest-ipywidgets): support pytest-playwright 0.7.0 #1006
+142
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Also, does this also add support for pytest-playwright 0.6.2 (or whichever 0.6 versions were broken previously)? Or would the support in the future be <0.6.2 >0.7, i.e. !=0.6.2
Also, #913 should probably be the issue that is referenced as fixed.
| @@ -284,7 +284,7 @@ jobs: | |||
| pip install `echo packages/solara-server/dist/*.whl`[all] | |||
| pip install `echo packages/solara-meta/dist/*.whl`[dev,documentation] | |||
| # pefile >= 2023.2.7 make pyinstaller incredibly slow https://github.com/erocarrera/pefile/issues/420 | |||
| pip install "jupyterlab<4" "pydantic<2" "playwright==1.41.2" pyinstaller pefile==2023.2.7 | |||
| pip install "jupyterlab<4" "pydantic<2" "playwright==1.50.0" pyinstaller pefile==2023.2.7 | |||
There was a problem hiding this comment.
Would it be best to unpin playwright to avoid similar issues in the future? Or maybe (if possible?) add an auto-upgrade scheme similar to the pre-commit ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #966