Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update code warining #901

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 20 additions & 21 deletions solara/website/pages/documentation/components/status/warning.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,27 +21,26 @@ def Page():
dense, set_dense = solara.use_state(False)
outlined, set_outlined = solara.use_state(True)
text, set_text = solara.use_state(True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also replace use_state with use_reactive here.

with solara.VBox() as main:
with solara.GridFixed(4):
solara.Checkbox(label="Use icon", value=icon, on_value=set_icon)
solara.Checkbox(label="Show dense", value=dense, on_value=set_dense)
solara.Checkbox(label="Show as text", value=text, on_value=set_text)
solara.Checkbox(label="Show outlined", value=outlined, on_value=set_outlined)
solara.Warning(
f"This is solara.Warning(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
text=text,
dense=dense,
outlined=outlined,
icon=icon,
)
solara.Warning(
f"This is solara.Warning(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
text=text,
dense=dense,
outlined=outlined,
icon=icon,
)
return main

with solara.GridFixed(4):
solara.Checkbox(label="Use icon", value=icon, on_value=set_icon)
solara.Checkbox(label="Show dense", value=dense, on_value=set_dense)
solara.Checkbox(label="Show as text", value=text, on_value=set_text)
solara.Checkbox(label="Show outlined", value=outlined, on_value=set_outlined)
solara.Warning(
f"This is solara.Warning(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
text=text,
dense=dense,
outlined=outlined,
icon=icon,
)
solara.Warning(
f"This is solara.Warning(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
text=text,
dense=dense,
outlined=outlined,
icon=icon,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate for some reason. Strange that we never noticed.

Suggested change
solara.Warning(
f"This is solara.Warning(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
text=text,
dense=dense,
outlined=outlined,
icon=icon,
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I already fix the two issues, if there is still any problem, please let me know.



__doc__ += apidoc(solara.Warning.f) # type: ignore
Loading