Fix layout cycle error in ProportionalStackPanel #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #366, resizing panels led to "Layout Cycle Detected" warning. This is not caused by a cycle like the message suggest, but we were changing
Proportion
from theMeasureOverride
andArrangeOverride
methods.https://github.com/wieslawsoltes/Dock/blob/master/src/Avalonia.Controls.ProportionalStackPanel/ProportionalStackPanel.cs#L224
I don't know if there is a better place to call
AssignProportions
(outside Measure and Arrange methods). Thus my proposal is to avoid calling InvalidateMeasure/InvalidateArrange when AssignProportions is being executed.AffectsParentMeasure
is just a syntax sugar forSo this PR basically only adds a flag to skip invalidating in this case.
Fixes: #366