Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit xml docs #28

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Do not emit xml docs #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e6e510
Do not emit xml docs
wieslawsoltes Dec 19, 2024
41f2926
Update tests
wieslawsoltes Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 3 additions & 33 deletions ...or.Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.ComplexTypesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand All @@ -32,48 +26,24 @@ namespace ReactiveGenerator
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for TestViewModel.
/// </summary>
public partial class TestViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the StringList property.
/// </summary>
private readonly ObservableAsPropertyHelper<global::System.Collections.Generic.List<string>?> _stringListHelper;
private ObservableAsPropertyHelper<global::System.Collections.Generic.List<string>?> _stringListHelper;

/// <summary>
/// Gets the current value of type System.Collections.Generic.List{string} from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial global::System.Collections.Generic.List<string>? StringList
{
get => _stringListHelper.Value;
}

/// <summary>
/// The ObservableAsPropertyHelper instance for the IntStringMap property.
/// </summary>
private readonly ObservableAsPropertyHelper<global::System.Collections.Generic.Dictionary<int, string>?> _intStringMapHelper;
private ObservableAsPropertyHelper<global::System.Collections.Generic.Dictionary<int, string>?> _intStringMapHelper;

/// <summary>
/// Gets the current value of type System.Collections.Generic.Dictionary{int, string} from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial global::System.Collections.Generic.Dictionary<int, string>? IntStringMap
{
get => _intStringMapHelper.Value;
}

/// <summary>
/// The ObservableAsPropertyHelper instance for the PersonInfo property.
/// </summary>
private readonly ObservableAsPropertyHelper<(string Name, int Age)> _personInfoHelper;
private ObservableAsPropertyHelper<(string Name, int Age)> _personInfoHelper;

/// <summary>
/// Gets the current value of type (string Name, int Age) from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial (string Name, int Age) PersonInfo
{
get => _personInfoHelper.Value;
Expand Down
24 changes: 4 additions & 20 deletions ...ts/ObservableAsPropertyHelperGeneratorTests.DifferentAccessibilityLevelsTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand All @@ -32,40 +26,30 @@ namespace ReactiveGenerator
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for TestViewModel.
/// </summary>
public partial class TestViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the PublicValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _publicValueHelper;
private ObservableAsPropertyHelper<string?> _publicValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? PublicValue
{
get => _publicValueHelper.Value;
}

private readonly ObservableAsPropertyHelper<string?> _protectedValueHelper;
private ObservableAsPropertyHelper<string?> _protectedValueHelper;

protected partial string? ProtectedValue
{
get => _protectedValueHelper.Value;
}

private readonly ObservableAsPropertyHelper<string?> _privateValueHelper;
private ObservableAsPropertyHelper<string?> _privateValueHelper;

private partial string? PrivateValue
{
get => _privateValueHelper.Value;
}

private readonly ObservableAsPropertyHelper<string?> _internalValueHelper;
private ObservableAsPropertyHelper<string?> _internalValueHelper;

internal partial string? InternalValue
{
Expand Down
18 changes: 1 addition & 17 deletions ...vableAsPropertyHelperGeneratorTests.GenericClassWithObservableAsPropertyTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand All @@ -32,20 +26,10 @@ namespace ReactiveGenerator
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for TestViewModel{T}.
/// </summary>
public partial class TestViewModel<T> where T : class
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the Value property.
/// </summary>
private readonly ObservableAsPropertyHelper<T?> _valueHelper;
private ObservableAsPropertyHelper<T?> _valueHelper;

/// <summary>
/// Gets the current value of type T from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial T? Value
{
get => _valueHelper.Value;
Expand Down
27 changes: 2 additions & 25 deletions ...ts/Snapshots/ObservableAsPropertyHelperGeneratorTests.GenericConstraintsTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand All @@ -32,34 +26,17 @@ namespace ReactiveGenerator
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for TestViewModel{T, U}.
/// </summary>
public partial class TestViewModel<T, U> where T : class, new() where U : struct, IComparable<U>
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the ReferenceValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<T?> _referenceValueHelper;
private ObservableAsPropertyHelper<T?> _referenceValueHelper;

/// <summary>
/// Gets the current value of type T from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial T? ReferenceValue
{
get => _referenceValueHelper.Value;
}

/// <summary>
/// The ObservableAsPropertyHelper instance for the ValueType property.
/// </summary>
private readonly ObservableAsPropertyHelper<U> _valueTypeHelper;
private ObservableAsPropertyHelper<U> _valueTypeHelper;

/// <summary>
/// Gets the current value of type U from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial U ValueType
{
get => _valueTypeHelper.Value;
Expand Down
30 changes: 2 additions & 28 deletions ...tor.Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.InheritanceTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,10 @@
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for BaseViewModel.
/// </summary>
public partial class BaseViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the BaseValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _baseValueHelper;
private ObservableAsPropertyHelper<string?> _baseValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? BaseValue
{
get => _baseValueHelper.Value;
Expand All @@ -39,20 +29,10 @@ public partial class BaseViewModel
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for DerivedViewModel.
/// </summary>
public partial class DerivedViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the DerivedValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _derivedValueHelper;
private ObservableAsPropertyHelper<string?> _derivedValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? DerivedValue
{
get => _derivedValueHelper.Value;
Expand All @@ -70,15 +50,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand Down
18 changes: 1 addition & 17 deletions ...Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.MixedAttributesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand All @@ -32,20 +26,10 @@ namespace ReactiveGenerator
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for TestViewModel.
/// </summary>
public partial class TestViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the ComputedValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _computedValueHelper;
private ObservableAsPropertyHelper<string?> _computedValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? ComputedValue
{
get => _computedValueHelper.Value;
Expand Down
42 changes: 3 additions & 39 deletions ...Snapshots/ObservableAsPropertyHelperGeneratorTests.MultiLevelInheritanceTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,10 @@
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for ChildViewModel.
/// </summary>
public partial class ChildViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the ChildValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _childValueHelper;
private ObservableAsPropertyHelper<string?> _childValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? ChildValue
{
get => _childValueHelper.Value;
Expand All @@ -39,20 +29,10 @@ public partial class ChildViewModel
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for GrandParentViewModel.
/// </summary>
public partial class GrandParentViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the GrandParentValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _grandParentValueHelper;
private ObservableAsPropertyHelper<string?> _grandParentValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? GrandParentValue
{
get => _grandParentValueHelper.Value;
Expand All @@ -70,15 +50,9 @@ using System;

namespace ReactiveGenerator
{
/// <summary>
/// Indicates that a property should be implemented as an ObservableAsPropertyHelper instance.
/// </summary>
[AttributeUsage(AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
public sealed class ObservableAsPropertyAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the ObservableAsPropertyAttribute class.
/// </summary>
public ObservableAsPropertyAttribute() { }
}
}
Expand All @@ -92,20 +66,10 @@ namespace ReactiveGenerator
using System;
using ReactiveUI;

/// <summary>
/// A partial class implementation with observable property helpers for ParentViewModel.
/// </summary>
public partial class ParentViewModel
{
/// <summary>
/// The ObservableAsPropertyHelper instance for the ParentValue property.
/// </summary>
private readonly ObservableAsPropertyHelper<string?> _parentValueHelper;
private ObservableAsPropertyHelper<string?> _parentValueHelper;

/// <summary>
/// Gets the current value of type string from the observable sequence.
/// </summary>
/// <value>The current value from the observable sequence.</value>
public partial string? ParentValue
{
get => _parentValueHelper.Value;
Expand Down
Loading
Loading