Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ReactiveDetectionHelper #33

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Introduce ReactiveDetectionHelper #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...or.Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.ComplexTypesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ using ReactiveUI;

public partial class TestViewModel
{
private ObservableAsPropertyHelper<global::System.Collections.Generic.List<string>?> _stringListHelper;
private ObservableAsPropertyHelper<global::System.Collections.Generic.List<string>> _stringListHelper;

public partial global::System.Collections.Generic.List<string>? StringList
public partial global::System.Collections.Generic.List<string> StringList
{
get => _stringListHelper.Value;
}

private ObservableAsPropertyHelper<global::System.Collections.Generic.Dictionary<int, string>?> _intStringMapHelper;
private ObservableAsPropertyHelper<global::System.Collections.Generic.Dictionary<int, string>> _intStringMapHelper;

public partial global::System.Collections.Generic.Dictionary<int, string>? IntStringMap
public partial global::System.Collections.Generic.Dictionary<int, string> IntStringMap
{
get => _intStringMapHelper.Value;
}
Expand Down
16 changes: 8 additions & 8 deletions ...ts/ObservableAsPropertyHelperGeneratorTests.DifferentAccessibilityLevelsTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,30 +28,30 @@ using ReactiveUI;

public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _publicValueHelper;
private ObservableAsPropertyHelper<string> _publicValueHelper;

public partial string? PublicValue
public partial string PublicValue
{
get => _publicValueHelper.Value;
}

private ObservableAsPropertyHelper<string?> _protectedValueHelper;
private ObservableAsPropertyHelper<string> _protectedValueHelper;

protected partial string? ProtectedValue
protected partial string ProtectedValue
{
get => _protectedValueHelper.Value;
}

private ObservableAsPropertyHelper<string?> _privateValueHelper;
private ObservableAsPropertyHelper<string> _privateValueHelper;

private partial string? PrivateValue
private partial string PrivateValue
{
get => _privateValueHelper.Value;
}

private ObservableAsPropertyHelper<string?> _internalValueHelper;
private ObservableAsPropertyHelper<string> _internalValueHelper;

internal partial string? InternalValue
internal partial string InternalValue
{
get => _internalValueHelper.Value;
}
Expand Down
8 changes: 4 additions & 4 deletions ...tor.Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.InheritanceTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ using ReactiveUI;

public partial class BaseViewModel
{
private ObservableAsPropertyHelper<string?> _baseValueHelper;
private ObservableAsPropertyHelper<string> _baseValueHelper;

public partial string? BaseValue
public partial string BaseValue
{
get => _baseValueHelper.Value;
}
Expand All @@ -31,9 +31,9 @@ using ReactiveUI;

public partial class DerivedViewModel
{
private ObservableAsPropertyHelper<string?> _derivedValueHelper;
private ObservableAsPropertyHelper<string> _derivedValueHelper;

public partial string? DerivedValue
public partial string DerivedValue
{
get => _derivedValueHelper.Value;
}
Expand Down
4 changes: 2 additions & 2 deletions ...Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.MixedAttributesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ using ReactiveUI;

public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _computedValueHelper;
private ObservableAsPropertyHelper<string> _computedValueHelper;

public partial string? ComputedValue
public partial string ComputedValue
{
get => _computedValueHelper.Value;
}
Expand Down
12 changes: 6 additions & 6 deletions ...Snapshots/ObservableAsPropertyHelperGeneratorTests.MultiLevelInheritanceTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ using ReactiveUI;

public partial class ChildViewModel
{
private ObservableAsPropertyHelper<string?> _childValueHelper;
private ObservableAsPropertyHelper<string> _childValueHelper;

public partial string? ChildValue
public partial string ChildValue
{
get => _childValueHelper.Value;
}
Expand All @@ -31,9 +31,9 @@ using ReactiveUI;

public partial class GrandParentViewModel
{
private ObservableAsPropertyHelper<string?> _grandParentValueHelper;
private ObservableAsPropertyHelper<string> _grandParentValueHelper;

public partial string? GrandParentValue
public partial string GrandParentValue
{
get => _grandParentValueHelper.Value;
}
Expand Down Expand Up @@ -68,9 +68,9 @@ using ReactiveUI;

public partial class ParentViewModel
{
private ObservableAsPropertyHelper<string?> _parentValueHelper;
private ObservableAsPropertyHelper<string> _parentValueHelper;

public partial string? ParentValue
public partial string ParentValue
{
get => _parentValueHelper.Value;
}
Expand Down
8 changes: 4 additions & 4 deletions ...ts/Snapshots/ObservableAsPropertyHelperGeneratorTests.MultipleNamespacesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ namespace First
{
public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _valueHelper;
private ObservableAsPropertyHelper<string> _valueHelper;

public partial string? Value
public partial string Value
{
get => _valueHelper.Value;
}
Expand Down Expand Up @@ -53,9 +53,9 @@ namespace Second
{
public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _valueHelper;
private ObservableAsPropertyHelper<string> _valueHelper;

public partial string? Value
public partial string Value
{
get => _valueHelper.Value;
}
Expand Down
4 changes: 2 additions & 2 deletions .../ObservableAsPropertyHelperGeneratorTests.MultipleObservableAsPropertiesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ using ReactiveUI;

public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _firstValueHelper;
private ObservableAsPropertyHelper<string> _firstValueHelper;

public partial string? FirstValue
public partial string FirstValue
{
get => _firstValueHelper.Value;
}
Expand Down
4 changes: 2 additions & 2 deletions ...rvableAsPropertyHelperGeneratorTests.NestedClassWithObservableAsPropertyTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ public partial class Container
{
public partial class NestedViewModel
{
private ObservableAsPropertyHelper<string?> _valueHelper;
private ObservableAsPropertyHelper<string> _valueHelper;

public partial string? Value
public partial string Value
{
get => _valueHelper.Value;
}
Expand Down
8 changes: 4 additions & 4 deletions ...ts/Snapshots/ObservableAsPropertyHelperGeneratorTests.NestedGenericTypesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ using ReactiveUI;

public partial class TestViewModel<T> where T : class
{
private ObservableAsPropertyHelper<global::System.Collections.Generic.List<global::System.Collections.Generic.Dictionary<string, T>>?> _complexPropertyHelper;
private ObservableAsPropertyHelper<global::System.Collections.Generic.List<global::System.Collections.Generic.Dictionary<string, T>>> _complexPropertyHelper;

public partial global::System.Collections.Generic.List<global::System.Collections.Generic.Dictionary<string, T>>? ComplexProperty
public partial global::System.Collections.Generic.List<global::System.Collections.Generic.Dictionary<string, T>> ComplexProperty
{
get => _complexPropertyHelper.Value;
}

private ObservableAsPropertyHelper<global::System.Collections.Generic.Dictionary<int, global::System.Collections.Generic.List<T>>?> _nestedPropertyHelper;
private ObservableAsPropertyHelper<global::System.Collections.Generic.Dictionary<int, global::System.Collections.Generic.List<T>>> _nestedPropertyHelper;

public partial global::System.Collections.Generic.Dictionary<int, global::System.Collections.Generic.List<T>>? NestedProperty
public partial global::System.Collections.Generic.Dictionary<int, global::System.Collections.Generic.List<T>> NestedProperty
{
get => _nestedPropertyHelper.Value;
}
Expand Down
8 changes: 4 additions & 4 deletions ...ts/Snapshots/ObservableAsPropertyHelperGeneratorTests.NestedPrivateClassTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ public partial class Container
{
private partial class PrivateViewModel
{
private ObservableAsPropertyHelper<string?> _valueHelper;
private ObservableAsPropertyHelper<string> _valueHelper;

public partial string? Value
public partial string Value
{
get => _valueHelper.Value;
}
Expand All @@ -36,9 +36,9 @@ public partial class Container
{
protected partial class ProtectedViewModel
{
private ObservableAsPropertyHelper<string?> _valueHelper;
private ObservableAsPropertyHelper<string> _valueHelper;

public partial string? Value
public partial string Value
{
get => _valueHelper.Value;
}
Expand Down
4 changes: 2 additions & 2 deletions ...ts/Snapshots/ObservableAsPropertyHelperGeneratorTests.NullablePropertiesTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ public partial class TestViewModel
get => _nullableStringHelper.Value;
}

private ObservableAsPropertyHelper<int??> _nullableIntHelper;
private ObservableAsPropertyHelper<int?> _nullableIntHelper;

public partial int?? NullableInt
public partial int? NullableInt
{
get => _nullableIntHelper.Value;
}
Expand Down
4 changes: 2 additions & 2 deletions ...hots/ObservableAsPropertyHelperGeneratorTests.SimpleObservableAsPropertyTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ using ReactiveUI;

public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _computedValueHelper;
private ObservableAsPropertyHelper<string> _computedValueHelper;

public partial string? ComputedValue
public partial string ComputedValue
{
get => _computedValueHelper.Value;
}
Expand Down
8 changes: 4 additions & 4 deletions ....Tests/Snapshots/ObservableAsPropertyHelperGeneratorTests.StaticPropertyTest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ using ReactiveUI;

public partial class TestViewModel
{
private ObservableAsPropertyHelper<string?> _staticValueHelper;
private ObservableAsPropertyHelper<string> _staticValueHelper;

public partial string? StaticValue
public partial string StaticValue
{
get => _staticValueHelper.Value;
}

private ObservableAsPropertyHelper<string?> _instanceValueHelper;
private ObservableAsPropertyHelper<string> _instanceValueHelper;

public partial string? InstanceValue
public partial string InstanceValue
{
get => _instanceValueHelper.Value;
}
Expand Down
Loading
Loading