Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiers #40

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Modifiers #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6095c7
Fix modifiers
wieslawsoltes Jan 3, 2025
81a3079
Add modifiers tests
wieslawsoltes Jan 3, 2025
07ca526
Update ReactiveGenerator.cs
wieslawsoltes Jan 3, 2025
f42a18e
Get 'new' modifier from syntax if present
wieslawsoltes Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
293 changes: 293 additions & 0 deletions ReactiveGenerator.Tests/ReactiveGenerator/ReactiveGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,4 +1269,297 @@ public partial class RegularClass

return TestAndVerify(source);
}

[Fact]
public Task RequiredPropertyTest()
{
var source = @"
[Reactive]
public partial class Person
{
public required partial string Name { get; set; }
public required partial int Age { get; set; }
public partial string? OptionalNickname { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task RequiredPropertyWithReactiveObjectTest()
{
var source = @"
using ReactiveUI;

[Reactive]
public partial class Person : ReactiveObject
{
public required partial string Name { get; set; }
public required partial DateOnly BirthDate { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task RequiredPropertyWithInheritanceTest()
{
var source = @"
[Reactive]
public abstract partial class Entity
{
public required partial string Id { get; set; }
}

[Reactive]
public partial class Person : Entity
{
public required partial string Name { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task RequiredPropertyWithMixedModifiersTest()
{
var source = @"
[Reactive]
public partial class BaseClass
{
public required virtual partial string VirtualRequired { get; set; }
}

[Reactive]
public partial class DerivedClass : BaseClass
{
public required override partial string VirtualRequired { get; set; }
public required partial string LocalRequired { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task AllPropertyModifiersTest()
{
var source = @"
[Reactive]
public partial class Base
{
// Static properties
public static partial string StaticProp { get; set; }
protected static partial string ProtectedStaticProp { get; set; }

// Virtual and abstract properties
public virtual partial string VirtualProp { get; set; }
public abstract partial string AbstractProp { get; set; }

// Required properties
public required partial string RequiredProp { get; set; }

// Mixed modifiers
public required virtual partial string RequiredVirtualProp { get; set; }
}

[Reactive]
public partial class Derived : Base
{
// New properties (shadowing)
public new partial string VirtualProp { get; set; }

// Override properties
public override partial string AbstractProp { get; set; }

// Sealed override properties
public sealed override partial string RequiredVirtualProp { get; set; }

// Static shadows
public new static partial string StaticProp { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task StaticPropertyTest()
{
var source = @"
[Reactive]
public partial class TestClass
{
public static partial string GlobalConfig { get; set; }
private static partial int Counter { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task NewModifierTest()
{
var source = @"
[Reactive]
public partial class Base
{
public partial string Name { get; set; }
}

[Reactive]
public partial class Derived : Base
{
public new partial string Name { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task SealedOverrideTest()
{
var source = @"
[Reactive]
public partial class Base
{
public virtual partial string VirtualProp { get; set; }
}

[Reactive]
public partial class Derived : Base
{
public sealed override partial string VirtualProp { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task MixedModifiersTest()
{
var source = @"
[Reactive]
public partial class TestClass
{
// Static + Required
public static required partial string StaticRequired { get; set; }

// New + Static
public new static partial string NewStatic { get; set; }

// Virtual + Required
public virtual required partial string VirtualRequired { get; set; }

// Override + Sealed
public sealed override partial string SealedOverride { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task AccessorModifiersTest()
{
var source = @"
[Reactive]
public partial class TestClass
{
// Property with private setter
public partial string Name { get; private set; }

// Protected property with private getter
protected partial string Id { private get; set; }

// Internal property with protected setter
internal partial string Code { get; protected set; }

// Public property with protected internal setter
public partial string Key { get; protected internal set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task ModifierOrderingTest()
{
var source = @"
[Reactive]
public partial class Base
{
// Base class properties for override/shadowing
public virtual partial string VirtualProp { get; set; }
protected virtual partial string ProtectedVirtualProp { get; set; }
public static partial string StaticProp { get; set; }
public abstract partial string AbstractProp { get; set; }
}

[Reactive]
public partial class Derived : Base
{
// Test new modifier comes first
public new partial string VirtualProp { get; set; }

// Test new + static ordering
public new static partial string StaticProp { get; set; }

// Test override + sealed + required ordering
public sealed override required partial string ProtectedVirtualProp { get; set; }

// Test override + required ordering
public override required partial string AbstractProp { get; set; }

// Test required only
public required partial string RequiredProp { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task InheritanceModifiersTest()
{
var source = @"
[Reactive]
public abstract partial class BaseClass
{
// Virtual property
public virtual partial string VirtualProp { get; set; }

// Abstract property
public abstract partial string AbstractProp { get; set; }
}

[Reactive]
public partial class DerivedClass : BaseClass
{
// Override property
public override partial string VirtualProp { get; set; }

// Sealed override property
public sealed override partial string AbstractProp { get; set; }
}";

return TestAndVerify(source);
}

[Fact]
public Task RequiredModifierTest()
{
var source = @"
[Reactive]
public partial class TestClass
{
// Required property
public required partial string Name { get; set; }

// Required with virtual
public virtual required partial string VirtualRequired { get; set; }

// Required with different access levels
protected required partial string ProtectedRequired { get; set; }
private required partial string PrivateRequired { get; set; }
}";

return TestAndVerify(source);
}
}
Loading
Loading