Added mac support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, it's helped @yiancar get it working on OSX. We're still deciding whether to wait for hidapi to apply this fix or revert back to the old way of using usage page/usage IDs. |
|
No problem. I'm glad to heard that it's helped someone else. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks for all of your work on this project and QMK.
This PR is to add mac support. Currently hidapi always returns
-1for the interface number in mac. There is a relatively new PR that adds interface number support for HID devices for macs, but it has not been merged yet.I added instructions on building hidapi from the current open PR to the readme, but I understand if you do not want to merge this until the PR is merged.