Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple and action distributions #41

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

will-maclean
Copy link
Owner

@will-maclean will-maclean commented Jun 22, 2024

For #32. Need both simple distributions and action distributions.

Simple Distributions

  • (trait)
  • Uniform
  • Normal
  • Categorical
  • Bernoulli

Action Distribution (https://github.com/DLR-RM/stable-baselines3/blob/master/stable_baselines3/common/distributions.py)

  • (trait)
  • DiagGaussianDistribution
  • SquashedDiagGaussianDistribution
  • CategoricalDistribution
  • MultiCategoricalDistribution
  • BernoulliDistribution
  • StateDependentNoiseDistribution
  • TanhBijector

@will-maclean will-maclean marked this pull request as draft June 22, 2024 14:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 88.06584% with 29 lines in your changes missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/common/distributions/distribution.rs 100.00% <100.00%> (ø)
src/common/utils/mod.rs 98.43% <ø> (ø)
src/common/utils/modules.rs 98.18% <98.18%> (ø)
src/common/distributions/normal.rs 94.94% <94.94%> (ø)
src/common/distributions/action_distribution.rs 86.30% <86.30%> (ø)
src/common/distributions/exp_family.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@will-maclean will-maclean marked this pull request as ready for review June 27, 2024 22:52
@will-maclean
Copy link
Owner Author

Going to merge this into main so it can be used as is now, but will convert the remaining distributions to an issue

@will-maclean will-maclean merged commit 6424915 into main Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants