Add IDA 7.[2-3] kernel32.{idb.i64} and fix tests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idb/analysis.py
Outdated
| jump_size = 1 if self.wordsize == 4 else 2 | ||
| jump_size2 = 0 if self.wordsize == 4 else 1 | ||
|
|
||
| if self.len_sbytes in (142, 173): | ||
| self.vsAddField("unknown-1", v_int8()) |
There was a problem hiding this comment.
recommend using an underscore rather than a dash, because vstruct will try to create an instance property with this name.
There was a problem hiding this comment.
I mean it just an index -1, because I don't want to resort the latter.
|
looking really good. i'll wait a little bit if you want to address the field name, otherwise, i'm happy to merge. |
XVilka
approved these changes
Jul 30, 2020
williballenthin
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing part of #57