Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print disambiguation message if display is the same #499

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

evant
Copy link
Collaborator

@evant evant commented Nov 29, 2023

if the types are different, add them to the error message, otherwise just print out that they don't compare equal

Fixes #449

Copy link
Contributor

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. I can spin the individual other cases from that issue into their own.

@evant evant force-pushed the same-display-distinction branch from 7af9d19 to b8989e2 Compare November 29, 2023 22:12
if the types are different, add them to the error message, otherwise
just print out that they don't compare equal

Fixes #449
@evant evant force-pushed the same-display-distinction branch from b8989e2 to 8ba5280 Compare November 30, 2023 19:47
@evant evant merged commit 0c0438f into main Nov 30, 2023
1 check passed
@evant evant deleted the same-display-distinction branch November 30, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages when things are not equal, but the result of toString() is the same.
2 participants