chore(refactor): add global db in memory support - driver builder 2/2 (WPB-8989) #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
vitorhugods,
alexandreferris,
a team,
typfel,
borichellow and
Garzas
and removed request for
a team
yamilmedina
changed the title
6 tasks
Datadog ReportBranch report: ✅ 0 Failed, 2934 Passed, 104 Skipped, 10.27s Total Time |
yamilmedina
changed the title
vitorhugods
approved these changes
May 10, 2024
persistence/src/androidMain/kotlin/com/wire/kalium/persistence/db/PlatformDatabaseData.kt
Outdated
Show resolved
Hide resolved
persistence/src/jvmMain/kotlin/com/wire/kalium/persistence/db/UserDatabase.kt
Outdated
Show resolved
Hide resolved
alexandreferris
approved these changes
May 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 10, 2024
* chore: in memory global db * fix: configure opening mode to nomutex * fix: journaling and tx mode * chore: remove debugging code * chore: running dockermode with default sequential warmup and more comments * chore: wip, extracting driver builder * chore: fix for apple platforms * refactor: unify creation of database pattern for globaldb * refactor: wrapping up * refactor: detekt * chore: add missing platform code migration * chore: rename * chore: fix persistence-test * chore: fix persistence-test * chore(refactor): add global db in memory support - driver builder 2/2 (WPB-8989) (#2751) * chore: pr comments * chore: pr comments * chore: align more pr comments * chore: align more pr comments * chore: detekt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
This PR addresses Builder pattern dsl and remove expect/actual for driver creation.
Solutions
Apply
dslbuilder pattern, suggested in prev. PR