-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: message composer option height update [WPB-11039] #3833
Conversation
Built wire-android-staging-compat-pr-3833.apk is available for download |
Built wire-android-dev-debug-pr-3833.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on my Android 9 device 👏
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3833 +/- ##
========================================
Coverage 45.28% 45.29%
========================================
Files 491 491
Lines 16952 16950 -2
Branches 2844 2843 -1
========================================
Hits 7677 7677
Misses 8489 8489
+ Partials 786 784 -2
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3833.apk is available for download |
Built wire-android-dev-debug-pr-3833.apk is available for download |
|
Built wire-android-staging-compat-pr-3833.apk is available for download |
Built wire-android-dev-debug-pr-3833.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
optionsHeight
was not updating to match the height of the keyboard on Android 9.Causes (Optional)
handleImeOffsetChange
function was relying onsource
instead ofoffset
to determine the keyboard height.source
did not consistently represent the correct height of the keyboard, leading to incorrectoptionsHeight
values.Solutions
handleImeOffsetChange
function to useoffset
instead ofsource
for checking and settingkeyboardHeight
andoptionsHeight
.