Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message composer option height update [WPB-11039] #3833

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 27, 2025

BugWPB-11039 [Android] Keyboard partially hiding attachment section


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Fixed an issue where optionsHeight was not updating to match the height of the keyboard on Android 9.
  • This issue caused UI elements, such as attachments, to be displayed incorrectly when the keyboard was open.

Causes (Optional)

  • The handleImeOffsetChange function was relying on source instead of offset to determine the keyboard height.
  • On Android 9, source did not consistently represent the correct height of the keyboard, leading to incorrect optionsHeight values.

Solutions

  • Updated the handleImeOffsetChange function to use offset instead of source for checking and setting keyboardHeight and optionsHeight.
  • Verified the changes on Android 9 and newer versions to ensure compatibility and consistent behavior across devices.

@Garzas Garzas self-assigned this Jan 27, 2025
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 27, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3833.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3833.apk is available for download

Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my Android 9 device 👏

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (c1ff13b) to head (68c3329).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3833   +/-   ##
========================================
  Coverage    45.28%   45.29%           
========================================
  Files          491      491           
  Lines        16952    16950    -2     
  Branches      2844     2843    -1     
========================================
  Hits          7677     7677           
  Misses        8489     8489           
+ Partials       786      784    -2     
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 65.00% <100.00%> (+1.58%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ff13b...68c3329. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3833.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3833.apk is available for download

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3833.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3833.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 4beedef Jan 30, 2025
13 checks passed
@MohamadJaara MohamadJaara deleted the fix/message-composer-options-height branch January 30, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants