Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle 2fa code in new login flow [WPB-15853] #3858

Merged
merged 2 commits into from
Feb 10, 2025
Merged

feat: handle 2fa code in new login flow [WPB-15853] #3858

merged 2 commits into from
Feb 10, 2025

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Feb 4, 2025 •
edited by github-actions bot
Loading

TaskWPB-15853 [Android] Implement UI for 2FA

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • new screen for entering 2FA code when logging in that reuses existing view model
  • updated some composable elements to be able to reuse them
  • navigation and dialogs handling from new login flow moved to dedicated composable function so that it can be reused on 2FA code screen (LoginStateNavigationAndDialogs)

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Build devDebug variant, switch to backend with 2FA enabled, log in and enter 2FA code.

Attachments (Optional)

newlogin-2facode.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Feb 4, 2025
@saleniuk saleniuk requested a review from yamilmedina February 4, 2025 17:10
@saleniuk saleniuk requested review from a team, sbakhtiarov, alexandreferris, vitorhugods, ohassine and mathias-niboulies and removed request for a team February 5, 2025 15:07
borichellow
borichellow approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small question :)

app/src/main/kotlin/com/wire/android/ui/newauthentication/login/NewLoginContainer.kt
NewLoginTitle("Enter your password to log in")
NewLoginTitle("Enter your password to log in")
NewLoginSubtitle("Enter your password to log in")
NewLoginSubtitle("Enter your password to log in")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't here be only 1 NewLoginSubtitle? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just for the preview to simulate situation when there are multiple texts inside the NewLoginHeader to make sure that the navigation icon button is placed properly 😃

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@saleniuk saleniuk merged commit 0df6522 into epic/new-sso-login-flow Feb 10, 2025
6 of 7 checks passed
@saleniuk saleniuk deleted the feat/newlogin-2fa-code branch February 10, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@borichellow borichellow borichellow approved these changes

@sbakhtiarov sbakhtiarov Awaiting requested review from sbakhtiarov sbakhtiarov was automatically assigned from wireapp/android

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@mathias-niboulies mathias-niboulies Awaiting requested review from mathias-niboulies mathias-niboulies was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
echoes/initiative: scale Enterprise Readiness Initiatives size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saleniuk @yamilmedina @borichellow