Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open ongoing call screen when answering an incoming call (WPB-15555) #3875

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 12, 2025

TaskWPB-15555 [Android] Calling UI should show up when answering a call


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to show calling UI after answering the call

Solutions

Answering the call and opening calling activity was not possible when the app is the background. The system is blocked that
Background activity launch blocked!

So the idea is to open Ongoing call screen and then answer the call from there.

Screen_recording_20250212_094332.webm

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, vitorhugods, Garzas and saleniuk and removed request for a team February 12, 2025 12:46
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 45.51%. Comparing base (e942709) to head (fdf334f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...in/com/wire/android/notification/PendingIntents.kt 0.00% 11 Missing ⚠️
...n/broadcastreceivers/IncomingCallActionReceiver.kt 0.00% 7 Missing ⚠️
...re/android/notification/CallNotificationManager.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3875      +/-   ##
===========================================
+ Coverage    45.50%   45.51%   +0.01%     
===========================================
  Files          491      491              
  Lines        17079    17072       -7     
  Branches      2854     2853       -1     
===========================================
- Hits          7771     7770       -1     
+ Misses        8513     8507       -6     
  Partials       795      795              
Files with missing lines Coverage Δ
.../android/ui/calling/ongoing/OngoingCallActivity.kt 0.00% <ø> (ø)
...re/android/notification/CallNotificationManager.kt 39.08% <0.00%> (-0.13%) ⬇️
...n/broadcastreceivers/IncomingCallActionReceiver.kt 4.00% <0.00%> (+0.29%) ⬆️
...in/com/wire/android/notification/PendingIntents.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e942709...fdf334f. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3875.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3875.apk is available for download

@ohassine ohassine changed the title feat: feat open ongoing call screen when answering an incoming call (WPB-15555) feat: open ongoing call screen when answering an incoming call (WPB-15555) Feb 14, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3875.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3875.apk is available for download

@MohamadJaara
Copy link
Member

i see in the code the getIncomingCallNotification have an action open incoming call with Open Call i think it is not needed anymore can it be removed ?

Copy link
Contributor

Built wire-android-staging-compat-pr-3875.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3875.apk is available for download

@ohassine
Copy link
Member Author

i see in the code the getIncomingCallNotification have an action open incoming call with Open Call i think it is not needed anymore can it be removed ?

yes still needed, it fixes #3859

@ohassine ohassine enabled auto-merge February 21, 2025 10:20
@ohassine ohassine added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit f017b0f Feb 21, 2025
11 of 12 checks passed
@ohassine ohassine deleted the open-calling-UI-when-answering-a-call branch February 21, 2025 11:10
Copy link
Contributor

Built wire-android-staging-compat-pr-3875.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3875.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants