Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia fix azure #4419

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Julia fix azure #4419

wants to merge 8 commits into from

Conversation

julialongtin
Copy link
Member

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 23, 2025
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving our documentation 👍

Have you checked the rendering of the page? It may be that some markup constructs don't work in Markdown as you're expecting them. It could be, that our Markdown renderer applies some additional magic, though ... 🤔

I tried to help with typos / grammar / Markdown syntax. IMHO the final approval should be left to someone who knows more about the details.

# How to set up SSO integration with Microsoft Entra ID

## Purpous and Scope
This document is for current and perspective users of the wire cloud, who want to manage their users with Microsoft Entra ID, in Azure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document is for current and perspective users of the wire cloud, who want to manage their users with Microsoft Entra ID, in Azure.
This document is for current and perspective users of the wire cloud, who want to manage their users with Microsoft Entra ID in Azure.


## Steps
### Creating a new application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, when do we use title case? (E.g. Purpose and Scope uses it 🤔 )


### Azure setup
```{image} 00.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work / render as expected?

Fill in user-facing app name, then click 'add':
This should have opened a 'Create your own application' window in the current page.
* Fill in the user-visible app name with the name for this application that you want your users to see.
* Leave the option selected next to 'Integrate with any other application you don\'t find in the gallery', then click 'add':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Markdown. There should be no need to quote '. In fact, ' is no special character in Markdown. Are you sure you aren't after *...* or **...** (italics and bold) whenever you use '...'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not after a visual display style; i'm after 'this is exactly the string you will see on screen' vs "I will type this".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the type face for this is block style. However, if you thought about it, this should be fine. (I was mostly worried about RestructuredText vs. Markdown misunderstandings 😅 )

Let's go straight to adding the two config parameters that are required, and saving.

In the 'Basic SAML Configuration' section, click on 'Edit'. This will bring up the 'Basic SAML Configuration' window.
* Enter <https://prod-nginz-https.wire.com/sso/finalize-login> for both 'Identifier (Entity ID)' and 'Reply URL(Assertion Consumer Service URL)'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Enter <https://prod-nginz-https.wire.com/sso/finalize-login> for both 'Identifier (Entity ID)' and 'Reply URL(Assertion Consumer Service URL)'.
* Enter `https://prod-nginz-https.wire.com/sso/finalize-login` for both 'Identifier (Entity ID)' and 'Reply URL(Assertion Consumer Service URL)'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants