-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia fix azure #4419
base: develop
Are you sure you want to change the base?
Julia fix azure #4419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for improving our documentation 👍
Have you checked the rendering of the page? It may be that some markup constructs don't work in Markdown as you're expecting them. It could be, that our Markdown renderer applies some additional magic, though ... 🤔
I tried to help with typos / grammar / Markdown syntax. IMHO the final approval should be left to someone who knows more about the details.
# How to set up SSO integration with Microsoft Entra ID | ||
|
||
## Purpous and Scope | ||
This document is for current and perspective users of the wire cloud, who want to manage their users with Microsoft Entra ID, in Azure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is for current and perspective users of the wire cloud, who want to manage their users with Microsoft Entra ID, in Azure. | |
This document is for current and perspective users of the wire cloud, who want to manage their users with Microsoft Entra ID in Azure. |
|
||
## Steps | ||
### Creating a new application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, when do we use title case? (E.g. Purpose and Scope uses it 🤔 )
|
||
### Azure setup | ||
```{image} 00.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work / render as expected?
Fill in user-facing app name, then click 'add': | ||
This should have opened a 'Create your own application' window in the current page. | ||
* Fill in the user-visible app name with the name for this application that you want your users to see. | ||
* Leave the option selected next to 'Integrate with any other application you don\'t find in the gallery', then click 'add': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Markdown. There should be no need to quote '
. In fact, '
is no special character in Markdown. Are you sure you aren't after *...*
or **...**
(italics and bold) whenever you use '...'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not after a visual display style; i'm after 'this is exactly the string you will see on screen' vs "I will type this".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the type face for this is block style
. However, if you thought about it, this should be fine. (I was mostly worried about RestructuredText vs. Markdown misunderstandings 😅 )
Let's go straight to adding the two config parameters that are required, and saving. | ||
|
||
In the 'Basic SAML Configuration' section, click on 'Edit'. This will bring up the 'Basic SAML Configuration' window. | ||
* Enter <https://prod-nginz-https.wire.com/sso/finalize-login> for both 'Identifier (Entity ID)' and 'Reply URL(Assertion Consumer Service URL)'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Enter <https://prod-nginz-https.wire.com/sso/finalize-login> for both 'Identifier (Entity ID)' and 'Reply URL(Assertion Consumer Service URL)'. | |
* Enter `https://prod-nginz-https.wire.com/sso/finalize-login` for both 'Identifier (Entity ID)' and 'Reply URL(Assertion Consumer Service URL)'. |
Co-authored-by: Sven Tennie <[email protected]>
Co-authored-by: Sven Tennie <[email protected]>
Co-authored-by: Sven Tennie <[email protected]>
Co-authored-by: Sven Tennie <[email protected]>
Checklist
changelog.d