-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ru): update some translations #2849
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I reviewed this PR as a non-native speaker with this checklist and everythings looks fine for me! Thanks for the nice translations!
Checked these related PRs:
- Expose
StarlightIcon
type #2805 - Fixes import name typo in Customize icons example #2572
- docs: fix invalid import in
ComponentProps
example #2751 - Fix outdated links to Expressive Code documentation #2782
- Add clientOptionsModule option to DocSearch plugin #2822
- Upgrade Pagefind to 1.3.0 and configure Pagefind logging levels #2728
- docs: add documentation for draft sidebar behavior #2825
I don't know if this is intentional, but these two files are not updated in this PR:
This doesn't in any way prevent us from merging this PR though, so everything is fine! Good job!
// Русская документация в `src/content/docs/ru/` | ||
ru: { | ||
label: 'Русский', | ||
// Арабская документация в `src/content/docs/ar/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left one comment regarding a change that I think should be reverted but otherwise, the translation looks great to me.
// Арабская документация в `src/content/docs/ar/` | ||
ar: { | ||
label: 'العربية', | ||
dir: 'rtl', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version looked fine to me. It was different from the English text because the example was updated to have defaultLocale: 'ru'
instead of defaultLocale: 'en'
and defaultLocale
must be one of the keys of the locales object so ar
was replaced by ru
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I forgot about defaultLocale
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks for the quick update to the PR 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed as a native speaker, I suggest some corrections
|
||
- `maxResultsPerGroup`: Ограничивает количество результатов, отображаемых для каждой группы поиска. По умолчанию `5`. | ||
- `disableUserPersonalization`: Предотвращает сохранение недавних поисков и избранных элементов пользователя в локальном хранилище. По умолчанию `false`. | ||
- `insights`: Включает плагин Algolia Insights и отправляет события поиска в ваш индекс DocSearch. По умолчанию `false`. | ||
- `searchParameters`: Объект, настраивающий [параметры поиска Algolia](https://www.algolia.com/doc/api-reference/search-api-parameters/). | ||
|
||
##### Дополнительные опции DocSearch | ||
|
||
Необходим отдельный файл конфигурации для передачи параметров функции, таких как `transformItems()` или `resultsFooterComponent()`, в компонент DocSearch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I think it would sound more natural to flip the order of the sentence a little
Необходим отдельный файл конфигурации для передачи параметров функции, таких как `transformItems()` или `resultsFooterComponent()`, в компонент DocSearch. | |
Для передачи в компонент DocSearch параметров-функций, таких как `transformItems()` или `resultsFooterComponent()`, необходим отдельный файл конфигурации. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно и так, или «функций с параметрами».
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не, мне кажется, там имелось в виду "параметры, значения которых являются функциями". Поэтому я сократил до "параметров-функций"
|
||
</Steps> | ||
|
||
Смотрите [Документацию по API клиента DocSearch JavaScript](https://docsearch.algolia.com/docs/api/), чтобы узнать все поддерживаемые параметры. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: something like this would be a more accurate translation, I think
Смотрите [Документацию по API клиента DocSearch JavaScript](https://docsearch.algolia.com/docs/api/), чтобы узнать все поддерживаемые параметры. | |
Смотрите [API-документацию к JavaScript-клиенту DocSearch](https://docsearch.algolia.com/docs/api/), чтобы узнать все поддерживаемые параметры. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так будет звучать, как будто документация принимает API-запросы, но ведь это не так?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API — это необязательно про запросы, это любой программный интерфейс. В английском просто часто используют "API reference" в значении "руководство по API", я здесь перевел это как "API-документация".
В целом, сейчас я перечитал твой вариант, и он тоже хороший, я бы только предложил передвинуть слово "JavaScript", чтоб было "JavaScript-клиенту DocSearch", потому что у DocSearch есть несколько клиентов для разных языков
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно и так. Создадите PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, скоро создам
@HiDeoo dang, you beat me to it... |
Oh, sorry, quite the timing indeed 😅 Feel free to open a new PR to propose the changes and maybe discuss them with @dragomano as native speakers are clearly the best and probably only ones who know what is best at this level of translation. |
Update:
ru/components/icons.mdx
ru/components/using-components/mdx
ru/guides/authoring-content.mdx
ru/guides/i18n.mdx
ru/guides/site-search.mdx
ru/reference/configuration.mdx
ru/reference/frontmatter.md
ru/reference/icons.mdx
ru/reference/plugins.md