Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ru): update some translations #2849

Merged
merged 11 commits into from
Feb 3, 2025
Merged

Conversation

dragomano
Copy link
Contributor

Update:

  • ru/components/icons.mdx
  • ru/components/using-components/mdx
  • ru/guides/authoring-content.mdx
  • ru/guides/i18n.mdx
  • ru/guides/site-search.mdx
  • ru/reference/configuration.mdx
  • ru/reference/frontmatter.md
  • ru/reference/icons.mdx
  • ru/reference/plugins.md

Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: c4a985c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 1, 2025
Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit c4a985c
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67a0939446ead900086c05ea
😎 Deploy Preview https://deploy-preview-2849--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Feb 1, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ru components/icons.mdx Localization changed, will be marked as complete.
ru components/using-components.mdx Localization changed, will be marked as complete.
ru guides/authoring-content.mdx Localization changed, will be marked as complete.
ru guides/i18n.mdx Localization changed, will be marked as complete.
ru guides/site-search.mdx Localization changed, will be marked as complete.
ru reference/configuration.mdx Localization changed, will be marked as complete.
ru reference/frontmatter.md Localization changed, will be marked as complete.
ru reference/icons.mdx Localization changed, will be marked as complete.
ru reference/plugins.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I reviewed this PR as a non-native speaker with this checklist and everythings looks fine for me! Thanks for the nice translations!

Checked these related PRs:

I don't know if this is intentional, but these two files are not updated in this PR:

This doesn't in any way prevent us from merging this PR though, so everything is fine! Good job!

// Русская документация в `src/content/docs/ru/`
ru: {
label: 'Русский',
// Арабская документация в `src/content/docs/ar/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left one comment regarding a change that I think should be reverted but otherwise, the translation looks great to me.

Comment on lines 271 to 275
// Арабская документация в `src/content/docs/ar/`
ar: {
label: 'العربية',
dir: 'rtl',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version looked fine to me. It was different from the English text because the example was updated to have defaultLocale: 'ru' instead of defaultLocale: 'en' and defaultLocale must be one of the keys of the locales object so ar was replaced by ru.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I forgot about defaultLocale :)

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the quick update to the PR 🚀

@HiDeoo HiDeoo merged commit f583430 into withastro:main Feb 3, 2025
15 checks passed
Copy link
Contributor

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as a native speaker, I suggest some corrections


- `maxResultsPerGroup`: Ограничивает количество результатов, отображаемых для каждой группы поиска. По умолчанию `5`.
- `disableUserPersonalization`: Предотвращает сохранение недавних поисков и избранных элементов пользователя в локальном хранилище. По умолчанию `false`.
- `insights`: Включает плагин Algolia Insights и отправляет события поиска в ваш индекс DocSearch. По умолчанию `false`.
- `searchParameters`: Объект, настраивающий [параметры поиска Algolia](https://www.algolia.com/doc/api-reference/search-api-parameters/).

##### Дополнительные опции DocSearch

Необходим отдельный файл конфигурации для передачи параметров функции, таких как `transformItems()` или `resultsFooterComponent()`, в компонент DocSearch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I think it would sound more natural to flip the order of the sentence a little

Suggested change
Необходим отдельный файл конфигурации для передачи параметров функции, таких как `transformItems()` или `resultsFooterComponent()`, в компонент DocSearch.
Для передачи в компонент DocSearch параметров-функций, таких как `transformItems()` или `resultsFooterComponent()`, необходим отдельный файл конфигурации.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно и так, или «функций с параметрами».

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не, мне кажется, там имелось в виду "параметры, значения которых являются функциями". Поэтому я сократил до "параметров-функций"


</Steps>

Смотрите [Документацию по API клиента DocSearch JavaScript](https://docsearch.algolia.com/docs/api/), чтобы узнать все поддерживаемые параметры.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: something like this would be a more accurate translation, I think

Suggested change
Смотрите [Документацию по API клиента DocSearch JavaScript](https://docsearch.algolia.com/docs/api/), чтобы узнать все поддерживаемые параметры.
Смотрите [API-документацию к JavaScript-клиенту DocSearch](https://docsearch.algolia.com/docs/api/), чтобы узнать все поддерживаемые параметры.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так будет звучать, как будто документация принимает API-запросы, но ведь это не так?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API — это необязательно про запросы, это любой программный интерфейс. В английском просто часто используют "API reference" в значении "руководство по API", я здесь перевел это как "API-документация".

В целом, сейчас я перечитал твой вариант, и он тоже хороший, я бы только предложил передвинуть слово "JavaScript", чтоб было "JavaScript-клиенту DocSearch", потому что у DocSearch есть несколько клиентов для разных языков

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно и так. Создадите PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, скоро создам

@illright
Copy link
Contributor

illright commented Feb 3, 2025

@HiDeoo dang, you beat me to it...

@HiDeoo
Copy link
Member

HiDeoo commented Feb 3, 2025

@HiDeoo dang, you beat me to it...

Oh, sorry, quite the timing indeed 😅 Feel free to open a new PR to propose the changes and maybe discuss them with @dragomano as native speakers are clearly the best and probably only ones who know what is best at this level of translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants