Add Arbitrum folder and governors/token contracts #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntourne
changed the title
|
This PRs look good to me. I'm not sure if we really need all the Arbitrum contracts, but Ledger can push back on that if we're asking too much. The other question I have is whether we are using |
|
@rsolari: Thanks for reviewing:
I'm not sure too. I added the 3 contracts (2 governors and 1 token) which we should deal with when voting or delegating.
Good question. Let me take a look again on what other dapps are doing. |
…ly/ledger-asset-dapps into feature/support-arbitrum
feat(Arbitrum): Remove b2c.json file feat(Arbitrum): Remove abis feat(Arbitrum): Minor feat(Arbitrum): Add arbitrum folder and contracts feat(Arbitrum): Fixes feat(Arbitrum): Update plugin value feat(Arbitrum): Remove b2c.json file feat(Arbitrum): Remove abis
…ly/ledger-asset-dapps into feature/support-arbitrum
… to 0x746d8A8FCAB7f829Fa500504f60D89C5CC1EA973.abi.json Update to right contract address & add new withdrawal functions to ABI: * batchWithdraw(validator_pubkeys) 0xe8a0c121 * batchWithdrawEL(validator_pubkeys) 0xef5e4682 * batchWithdrawCL(validator_pubkeys) 0x0ffab6c2 * requestValidatorsExit(validator_pubkeys) 0xb6b06dec
Update to right contract address & add new withdrawal functions to ABI: * batchWithdraw(validator_pubkeys) 0xe8a0c121 * batchWithdrawEL(validator_pubkeys) 0xef5e4682 * batchWithdrawCL(validator_pubkeys) 0x0ffab6c2 * requestValidatorsExit(validator_pubkeys) 0xb6b06dec
Add contract names
…e-introduced with script 8.2.0
author Berg Jefferson <[email protected]> 1684422419 +0800 committer Nicolas Tourne <[email protected]> 1687524042 -0300 parent f233f1c author Berg Jefferson <[email protected]> 1684422419 +0800 committer Nicolas Tourne <[email protected]> 1687524006 -0300 add DeGate feat(Arbitrum): Add arbitrum folder and contracts feat(Arbitrum): Change contractName feat(Arbitrum): Fixes feat(Arbitrum): Update plugin value feat(Arbitrum): Remove b2c.json file feat(Arbitrum): Remove abis feat(Arbitrum): Minor feat(Arbitrum): Add arbitrum folder and contracts feat(Arbitrum): Fixes feat(Arbitrum): Update plugin value feat(Arbitrum): Remove b2c.json file feat(Arbitrum): Remove abis feat(Arbitrum): Remove b2c.json file feat(Arbitrum): Remove abis feat(Arbitrum): Add arbitrum folder and contracts feat(Arbitrum): Fixes feat(Arbitrum): Update plugin value
…ly/ledger-asset-dapps into feature/support-arbitrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.