android(feat):new arch support #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # detox/android/detox/src/full/java/com/wix/detox/reactnative/idlingresources/animations/AnimatedModuleIdlingResource.kt
Change the way of getting is fabric enabled
Change the way of getting is fabric enabled
asafkorem
reviewed
Jan 13, 2025
|
@gosha212 I think the test app will crash on the Localization screen on Android, since it uses a legacy native module. |
|
we should check if our bridge native modules work with backward comp. or if there's something magically /hybrid that happens here |
asafkorem
requested changes
Jan 14, 2025
d4vidi
requested changes
Jan 14, 2025
.../demo-react-native/android/app/src/androidTest/java/com/example/DetoxTestAppJUnitRunner.java
Show resolved
Hide resolved
examples/demo-react-native/android/app/src/main/java/com/example/MainActivity.kt
Show resolved
Hide resolved
detox/android/detox/src/full/java/com/wix/detox/reactnative/reloader/ReactNativeReloader.kt
Outdated
Show resolved
Hide resolved
...src/full/java/com/wix/detox/reactnative/idlingresources/timers/FabricTimersIdlingResource.kt
Outdated
Show resolved
Hide resolved
...src/full/java/com/wix/detox/reactnative/idlingresources/timers/FabricTimersIdlingResource.kt
Show resolved
Hide resolved
...src/full/java/com/wix/detox/reactnative/idlingresources/timers/FabricTimersIdlingResource.kt
Outdated
Show resolved
Hide resolved
...src/full/java/com/wix/detox/reactnative/idlingresources/timers/FabricTimersIdlingResource.kt
Outdated
Show resolved
Hide resolved
…lingresources/uimodule/fabric/FabricUIManagerIdlingResources.kt Co-authored-by: d4vidi <[email protected]>
Co-authored-by: d4vidi <[email protected]>
d4vidi
reviewed
Jan 15, 2025
detox/android/detox/build.gradle
Outdated
Comment on lines
150
to
155
| api('androidx.test:core-ktx:1.6.1') { | ||
| because 'Needed by Detox but also makes AndroidX test core seamlessly provided to Detox users with hybrid apps/E2E-tests.' | ||
| } | ||
| api("org.jetbrains.kotlin:kotlin-reflect:$_kotlinVersion") { | ||
| because('Needed by Detox for kotlin reflection') | ||
| } |
There was a problem hiding this comment.
on 2nd thought, maybe implementation would be a better idea here
d4vidi
reviewed
Jan 15, 2025
...om/wix/detox/reactnative/idlingresources/factory/FabricDetoxIdlingResourceFactoryStrategy.kt
Outdated
Show resolved
Hide resolved
d4vidi
reviewed
Jan 15, 2025
.../detox/src/full/java/com/wix/detox/reactnative/idlingresources/timers/JavaTimersReflected.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have added support for the new arch in detox