wip: test bitbox tapminiscript update #1357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
changed the title
edouardparis
force-pushed
the
bitbox-tapminiscript
branch
from
184be2c
to
42a290a
Compare
nondiremanuel
added
Signing devices
edouardparis
added a commit
that referenced
this pull request
Nov 4, 2024
01f6d2b gui: add support for tapminiscript on bitbox02 (pythcoiner) Pull request description: This PR is build on top of #1357, with few adds: - get the version from bitbox device - check the version for taproot support - copy `tap_script_signs` & `tap_key_sig` if present in the pruned psbt after signature Tested spending by internal key & taptree w/ differents setups ~~Note: this PR use `bitbox-tapminiscript` branch of `async-hwi`~~ ACKs for top commit: edouardparis: ACK 01f6d2b Tree-SHA512: aa66a0ebe8553fd13dd5e279adaf1360cdce0d4ccb09f49181f20bc5e4c3c653c0ab056c35ac5cf6ccb3eeb696dcfd94463e6235d1cdb2063ecb503695ad4b99
|
deprecated in favor of #1400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.