[FIX] 26.11.2024: fix xpathes because uploading videos failed. #177
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavanphat
reviewed
Oct 27, 2024
src/tiktok_uploader/upload.py
Outdated
Comment on lines
752
to
755
| tmp = "/html/body/div[1]/div/div[2]/div[2]/div/div/div/div/div[3]/div/div[2]/div[10]/button[1]" | ||
| post = WebDriverWait(driver, config["implicit_wait"]).until( | ||
| EC.element_to_be_clickable( | ||
| (By.XPATH, config["selectors"]["upload"]["post"]) | ||
| (By.XPATH, tmp) # config["selectors"]["upload"]["post"] was instead of tmp |
There was a problem hiding this comment.
You should change value in config file instead of tmp variable and use this value //button[@data-e2e="post_video_button"]
src/tiktok_uploader/upload.py
Outdated
Comment on lines
767
to
769
| tmp1 = "/html/body/div[6]/div/div/div[3]/button[2]" | ||
| post_confirmation = EC.presence_of_element_located( | ||
| (By.XPATH, config["selectors"]["upload"]["post_confirmation"]) | ||
| (By.XPATH, tmp1) # config["selectors"]["upload"]["post_confirmation"] was instead of tmp1 |
There was a problem hiding this comment.
Same above comment, you should change value in config file instead of tmp variable
lavanphat
approved these changes
Oct 28, 2024
wkaisertexas
requested changes
Nov 4, 2024
| @@ -55,8 +55,8 @@ user_agent = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTM | |||
| duet = "//label[.='Duet']/following-sibling::div/input" | |||
| stitch = "//label[.='Stitch']/following-sibling::div/input" | |||
|
|
|||
| post = "//button[contains(@class, 'TUXButton--primary')]" | |||
| post_confirmation = "//div[contains(text(), 'Your video has been uploaded')]" | |||
| post = "//*[@id=\"root\"]/div/div[2]/div[2]/div/div/div/div/div[3]/div/div[2]/div[10]/button[1]" | |||
There was a problem hiding this comment.
This is too fragile of an xpath
Did you build and test these changes locally? What did you do to know that it looks good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had troubles in uploading new videos, so i debugged the library and changed 2 xpathes because they were wrong. I suppose they are outdated. Also i commented 2 lines of code, which failed.
I did not dive deep in the logic and just made fixes so it works.