Fix tests for Windows #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now, all tests pass on Windows except for |
|
@RunDevelopment Now I added CI for Windows that uses make command with : #324 I'll work on updating the tests next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313.
Changes:
shlex.split. Since windows paths use\, string interpolation +shlex.splitwill result in those backslashes being interpreted as escape sequences. So I used argument arrays everywhere instead./tmpis a directory that exists.tempfile.NamedTemporaryFile(). The named file is opened by the test process, which means that it cannot be written to by a sub process on windows.makedoesn't exist on Windows, I copied the test command.