Do not use file globbing in the build system #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the build configuration more robust to added and removed files. See also the analogous PR in ROOT, as well as the corresponding Jira ticket: * root-project/root#3259 * https://its.cern.ch/jira/browse/ROOT-5998 Like this, we also don't need to "comment out" whole source files with preprocessor macros, like the `TPyClassGenerator`. This also helps ROOT, which requires these sources, because then the sources can be used as-is.
|
I wouldn't uncomment the TPyClassGenerator file as it really can't compile at this point. It accesses ROOT headers directly rather than clingwrapper APIs. The point of that file was to make Python classes usable from Cling. It's a cute feature, but no-one really ever cared about it, since callbacks (through a C++ base class) are easier to deal with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the build configuration more robust to added and removed files.
See also the analogous PR in ROOT, as well as the corresponding Jira ticket:
Like this, we also don't need to "comment out" whole source files with preprocessor macros, like the
TPyClassGenerator. This also helps ROOT, which requires these sources, because then the sources can be used as-is.