Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wolfCrypt tests to unit tests #61

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

bigbrett
Copy link
Contributor

@bigbrett bigbrett commented Aug 2, 2024

Creates a unit test to run wolfCrypt tests on top of wolfHSM, and adds as a CI job.

This will keep failing CI until we can actually pass wolfCrypt tests, so I've got it off by default in the unit tests (use TESTWOLFCRYPT=1 to enable), and have it set to pass CI even though unit tests fail.

Once we are able to pass wolfCrypt tests, we can remove the ||true in the CI job. For now, it is just nice to have as a progress indicator.

@bigbrett bigbrett force-pushed the test-add-wolfcrypt-tests branch from 55b90f7 to 87acf8b Compare August 2, 2024 20:21
@bigbrett bigbrett force-pushed the test-add-wolfcrypt-tests branch 2 times, most recently from f4fcd5e to bf48a55 Compare August 9, 2024 15:23
@bigbrett bigbrett force-pushed the test-add-wolfcrypt-tests branch from bf48a55 to b93c131 Compare August 9, 2024 15:24
@bigbrett bigbrett marked this pull request as ready for review August 9, 2024 16:06
@bigbrett bigbrett requested review from billphipps and jpbland1 August 9, 2024 16:06
Copy link
Contributor

@billphipps billphipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@billphipps billphipps merged commit 04ce9cf into wolfSSL:main Aug 9, 2024
1 check passed
jefferyq2 pushed a commit to jefferyq2/wolfHSM that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants