Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic app and script for wolfJCE benchmark #88

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jackctj117
Copy link

@jackctj117 jackctj117 commented Dec 23, 2024

Initial outline for wolfJCE Security Cryptography API benchmark app

@jackctj117 jackctj117 requested a review from cconlon December 23, 2024 18:49
@jackctj117 jackctj117 self-assigned this Dec 23, 2024
@jackctj117 jackctj117 changed the title ChatGPT basic app and script Basic app and script Dec 23, 2024
@jackctj117 jackctj117 changed the title Basic app and script Basic app and script for wolfJSSE benchmark Dec 23, 2024
@jackctj117 jackctj117 force-pushed the wolfJSSE_Benchmark branch 2 times, most recently from 7607977 to 11bef90 Compare December 23, 2024 19:18
Copy link
Member

@cconlon cconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback comments. Also please rename commit to mention "wolfJCE" instead of "wolfJSSE". This is only a crypto-level benchmark, not an SSL/TLS benchmark (JSSE level).

examples/provider/CryptoBenchmark.java Outdated Show resolved Hide resolved
examples/provider/CryptoBenchmark.java Outdated Show resolved Hide resolved
examples/provider/CryptoBenchmark.java Outdated Show resolved Hide resolved
examples/provider/CryptoBenchmark.java Outdated Show resolved Hide resolved
@jackctj117
Copy link
Author

Newest push should fix previous concerns

examples/provider/CryptoBenchmark.java Outdated Show resolved Hide resolved
examples/provider/CryptoBenchmark.java Outdated Show resolved Hide resolved
Copy link
Member

@cconlon cconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments. Also please squash all commits into a single one.

examples/provider/CryptoBenchmark.sh Outdated Show resolved Hide resolved
examples/provider/CryptoBenchmark.java Show resolved Hide resolved
@cconlon cconlon merged commit fb80126 into wolfSSL:master Dec 24, 2024
36 checks passed
@cconlon cconlon changed the title Basic app and script for wolfJSSE benchmark Basic app and script for wolfJCE benchmark Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants