Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _methods.py: Fix typo #45

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link

@cclauss cclauss commented Nov 24, 2023

No description provided.

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@anhu anhu self-assigned this Nov 24, 2023
@anhu
Copy link
Member

anhu commented Nov 24, 2023

Hi @cclauss ,

My name is Anthony and I am a member of the wolfSSL team.

Thank you so much for pointing out this spelling mistake in our output. We typically do not accept such small contributions from external sources since external contributions require the contributor to sign a contributor agreement; instead it would be considered a bug report.

That said, let me confer with my team. Please stay tuned.

Warm regards, Anthony

@cclauss
Copy link
Author

cclauss commented Nov 27, 2023

We typically do not accept such small contributions from external sources since external contributions require the contributor to sign a contributor agreement

I typically do not make large contributions to open-source projects until I see how a trivial contribution is reviewed.

https://www.wolfssl.com/about/wolfssl-software-development-process-quality-assurance does not mention a contributor agreement. I would be happy to sign one if the terms are reasonable.

@anhu
Copy link
Member

anhu commented Nov 27, 2023

Hello @cclauss ,

For submissions such as this one, we will typically correct our mistake in a different way, such as by re-wording the comment ourselves. Essentially, we treat the PR as a bug report. Please see #46 .

We would be happy to accept your larger and more significant contributions. Once you have put up such a PR we would then send you the contribution agreement.

@cclauss cclauss closed this Nov 27, 2023
@cclauss cclauss deleted the patch-1 branch November 27, 2023 16:48
@JacobBarthelmeh JacobBarthelmeh mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants