Add support for Mosquitto OSP #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareem-wolfssl
requested changes
May 31, 2023
kareem-wolfssl
previously requested changes
Jun 2, 2023
There was a problem hiding this comment.
Looks good to me. Seeing some test failures from Mosquitto which we discussed on Slack.
Apologies for forgetting this in the initial review, we are trying to test all OSP integrations using Github Actions. Please add an action to test Mosquitto. The tests are located in .github/workflows
embhorn
force-pushed
the
mosquitto_osp
branch
from
94082f3 to
40c49a7
Compare
embhorn
force-pushed
the
mosquitto_osp
branch
from
853b060 to
8271af5
Compare
|
Converted to draft. Will revisit effort when prioritized. |
julek-wolfssl
requested changes
Jun 7, 2024
embhorn
force-pushed
the
mosquitto_osp
branch
5 times, most recently
from
2a33a61 to
11113d8
Compare
julek-wolfssl
requested changes
Jun 10, 2024
.github/workflows/mosquitto.yml
Outdated
| sudo apt-get install -y build-essential libev-dev libssl-dev automake python3-docutils libcunit1 libcunit1-doc libcunit1-dev pkg-config make | ||
|
|
||
| - name: Checkout mosquitto | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@v3 | |
| uses: actions/checkout@v4 |
julek-wolfssl
requested changes
Jun 10, 2024
.github/workflows/mosquitto.yml
Outdated
| run: | | ||
| cd $GITHUB_WORKSPACE/mosquitto/ | ||
| patch -p1 < $GITHUB_WORKSPACE/osp/mosquitto/${{ matrix.ref }}.patch | ||
| make WITH_TLS=wolfssl WITH_CJSON=no WITH_DOCS=no -j |
There was a problem hiding this comment.
Will need to use WOLFSSLDIR to point to the location of wolfSSL.
|
Tabs-to-spaces from my editor messed up the patch file |
embhorn
force-pushed
the
mosquitto_osp
branch
2 times, most recently
from
5be1476 to
6648df3
Compare
|
Fixed a bunch of failing mosquitto tests by concatenating the server cert with the CA. Should be good for final review now. |
julek-wolfssl
previously approved these changes
Jul 16, 2024
julek-wolfssl
approved these changes
Jul 18, 2024
dgarske
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support mosquitto OSP
Add
SSL_CTX_set_dh_autostubAdd
--enable-mosquittoconfig optionTesting
wolfSSL
Mosquito OSP patch
https://github.com/wolfSSL/osp/blob/master/mosquitto/2.0.18.patch
Eclipse Mosquitto
Checklist