Add left-most wildcard matching support to X509_check_host() #7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconlon
force-pushed
the
x509CheckHostLeftWildcardOnly
branch
from
56157cb to
f878220
Compare
douzzer
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds left-most only wildcard matching to
wolfSSL_X509_check_host()by introducing a new custom function flag calledWOLFSSL_LEFT_MOST_WILDCARD_ONLY.Left-most wildcard matching support is used for the Server Identity Check in RFC 2830 (Lightweight Directory Access Protocol (v3): Extension for Transport Layer Security). This matching support added in this PR will be consumed/used by wolfJSSE LDAPS endpoint identification support, which will be opened in a separate PR on wolfssljni.
Testing
Unit tests have been added to
tests/api.c.Checklist