Check r and s len before copying #8350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
SparkiDev
approved these changes
Jan 13, 2025
SparkiDev
previously requested changes
Jan 13, 2025
dgarske
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DecodeECC_DSA_Sig_Bin()does not take into account the rLen and sLen values provided as input. These parameters are intended to represent the sizes of the buffers for r and s, as outlined in the documentation for wc_ecc_sig_to_rs().Fix checks len values and returns
ASN_PARSE_Eif too small to hold sig component.Fixes zd19220
Testing
./configure --enable-asn=originalChecklist