-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Package Metadata ELF notes by including melange generated gcc specs for C, C++, Rust, Go. #39152
Draft
xnox
wants to merge
1
commit into
wolfi-dev:main
Choose a base branch
from
xnox:ossf-package-notes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0199aff
to
fad19ce
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
xnox
added a commit
that referenced
this pull request
Jan 16, 2025
This is part 1 / pre-requisite to land: - #39152 If exist, include melange generated spec file from workspace. No errors produced if the melange generated spec file is missing. Potentially worth exploring to also always load $HOME/.gcc.spec, which may make it easier to customize gcc spec files on per-package basis.
ee36bce
to
3bad54d
Compare
As an e2e test for three packages (written in C/Go/Rust). This enables using the future spec file with melange generated spec file include. When these land in images, and SBOM/Vulnerability/Console all look good we can roll this out by default.
3bad54d
to
3880c2c
Compare
This now builds with elf notes; it will affect gitlab and cilium images.
|
and boom
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved-to-run
A repo member has approved this external contribution
bincapz/pass
bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
blocked
indicates there are blocking issues that need to be addressed before progress can be made
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot land this PR in one go, thus split openssf-compiler-options (first commit) into separate PR to land first:
openssf-compiler-options: include melange spec files #39242
openssf-compiler-options: include melange spec files
If exist, include melange generated spec file from workspace.
No errors produced if the melange generated spec file is missing.
Potentially worth exploring to also always load $HOME/.gcc.spec, which
may make it easier to customize gcc spec files on per-package basis.
Use new spec file with optional include
As an e2e test for three packages (written in C/Go/Rust). This enables
using the future spec file with melange generated spec file include.
When these land in images, and SBOM/Vulnerability/Console all look
good we can roll this out by default.
NB! This PR needs melange that generates the dynamic gcc spec file which is being optionally included.
Once this lands for three packages in question, images are tested, and any bugs/issues resolved, we can remove the opt-in, and make the ELF notes the default.