Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Budget Recommendations values #2166

Merged
merged 13 commits into from
Nov 30, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Nov 30, 2023

Merges #2153 into develop

We do add the tracks after in a separate feature to at least have the budget recommendations in the next release.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2166 (2b9b5ae) into develop (9cc4551) will decrease coverage by 0.1%.
Report is 27 commits behind head on develop.
The diff coverage is 21.4%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #2166     +/-   ##
===========================================
- Coverage       58.3%   58.2%   -0.1%     
- Complexity      4119    4127      +8     
===========================================
  Files            452     453      +1     
  Lines          17677   17691     +14     
===========================================
- Hits           10301   10300      -1     
- Misses          7376    7391     +15     
Flag Coverage Δ
php-unit-tests 58.2% <21.4%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Controllers/Ads/BudgetRecommendationController.php 100.0% <100.0%> (ø)
src/DB/TableInterface.php 0.0% <ø> (ø)
...nternal/DependencyManagement/DBServiceProvider.php 0.0% <0.0%> (ø)
src/DB/Table/BudgetRecommendationTable.php 57.7% <20.0%> (+1.1%) ⬆️
src/DB/Table.php 9.1% <0.0%> (-1.6%) ⬇️
src/DB/Migration/Migration20231109T1653383133.php 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

@puntope puntope merged commit 8e42937 into develop Nov 30, 2023
14 of 16 checks passed
@puntope puntope deleted the feature/budget-recommendations-logic branch November 30, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant