Make the names of PHP classes, interfaces and traits in code comments consistent with the actual names #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistent with the actual names.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2752 +/- ##
============================================
+ Coverage 63.3% 67.0% +3.7%
- Complexity 0 4690 +4690
============================================
Files 337 479 +142
Lines 5211 19601 +14390
Branches 1278 0 -1278
============================================
+ Hits 3300 13141 +9841
- Misses 1737 6460 +4723
+ Partials 174 0 -174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR makes the names of PHP classes, interfaces and traits in code comments consistent with the actual names, especially since some names are completely irrelevant.
(Noticed these inconsistencies while working on the shipping improvement project)
💡 I will likely skip code review since this PR only includes developer-facing change.
Detailed test instructions:
Check if the updated names are consistent with the actual ones.
Changelog entry