Allow mapping of a Google ID without a prefix #2773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR makes the prefix when fetching status from the Merchant Center as optional. We do want to make sure that the ID is a strictly numeric ID otherwise it's not accepted. In the previous regex we searched till end of string with
$
, but didn't force it to search from the start of the string with^
. This meant that it was possible to a map an ID likefoo_gla_12345
. We fixed this in the PR to ensure it scans the whole string for a matching pattern:gla_
+ numeric IDAny other patterns will result in an unmapped ID. I've added additional unit tests to cover all these variations.
Closes #2768
Detailed test instructions:
unsynced
Changelog entry