Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility testing with Woo 8.8 #215

Merged
merged 4 commits into from
May 6, 2024
Merged

Compatibility testing with Woo 8.8 #215

merged 4 commits into from
May 6, 2024

Conversation

ankitguptaindia
Copy link
Member

All Submissions:

  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

  • Bump WooCommerce "tested up to" version 8.8
  • Bump WooCommerce minimum supported version to 8.6

Closes #213

Steps to test the changes in this Pull Request:

  1. Run the e2e test using GitHub action to test this PR
  2. All tests should be passed.
  3. Manual Test - The plugin should give Notice when using an unsupported version of WooCommerce and WordPress.

Changelog entry

Dev - Bump WooCommerce "tested up to" version 8.8.
Dev - Bump WooCommerce minimum supported version to 8.6.

@dkotter
Copy link
Contributor

dkotter commented Apr 16, 2024

Code here looks fine but E2E tests are failing which will need further investigation cc / @vikrampm1

@ankitguptaindia
Copy link
Member Author

@iamdharmesh Could you please fix failed e2e cases? thanks!

@iamdharmesh
Copy link
Member

@ankitguptaindia E2E tests are fixed. Failure was due to place order button label updates for the subscription. It's fixed now.

Thanks.

@vikrampm1 vikrampm1 added this to the Future Release milestone Apr 29, 2024
@jeffpaul jeffpaul marked this pull request as ready for review May 6, 2024 13:12
@jeffpaul jeffpaul merged commit c9af36e into trunk May 6, 2024
5 checks passed
@jeffpaul jeffpaul deleted the compat-woo-8.8 branch May 6, 2024 13:12
@jeffpaul jeffpaul modified the milestones: Future Release, 1.6.4 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility testing with Woo 8.8
5 participants