New SEPA Direct Debit integration (3698) #2855
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InpsydeNiklas
requested review from
danielhuesken,
danieldudzic,
stracker-phil and
Narek13
Narek13
reviewed
Nov 29, 2024
| * | ||
| * @var Orders | ||
| */ | ||
| private $orders_endpoint; |
There was a problem hiding this comment.
I would suggest to always add typehints since we are already on PHP 7.4 +
Suggested change
| private $orders_endpoint; | |
| private Orders $orders_endpoint; |
There was a problem hiding this comment.
I agree with this suggestion; when possible, we should use the type hints.
Just want to point out that this is only possible for custom properties, and we cannot add a type hint for properties that are defined without a type in the base class
Narek13
reviewed
Nov 29, 2024
|
|
||
| use ProcessPaymentTrait; | ||
|
|
||
| const ID = 'ppcp-sepa'; |
There was a problem hiding this comment.
Suggested change
| const ID = 'ppcp-sepa'; | |
| public const ID = 'ppcp-sepa'; |
Narek13
reviewed
Nov 29, 2024
| * | ||
| * @var string | ||
| */ | ||
| private $module_url; |
There was a problem hiding this comment.
Same here, missing typehints for the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SEPA direct debit.
SEPA direct debit features
SEPA Direct Debit allows you to access funds immediately if you opt for Instant Settlements. Delayed settlement option will make funds available in the standard SEPA settlement timeframe of 2-3 days.