Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing subscription payment method to ACDC results in an error (3949) #2891

Open
wants to merge 11 commits into
base: trunk
Choose a base branch
from

Conversation

Dinamiko
Copy link
Contributor

@Dinamiko Dinamiko commented Dec 9, 2024

When an active subscription from another payment method, e.g. Stripe, is switched to ACDC from the my-account section, an error will be displayed in the frontend.

Steps To Reproduce

  • buy a subscription with a third-party payment method like Stripe
  • ensure ACDC Vaulting is enabled
  • in my-account > Payment methods section, click “Add payment method”
  • add an ACDC card, like 2223000048400011
  • navigate to the subscription in my-account > Subscriptions > Change payment
  • change the payment method to the saved ACDC token
    • observe an error in the frontend that the payment method could not be changed
  • in subscription admin, observe that the payment method was changed despite the error
  • upon triggering a renewal, observe error PAYMENT_SOURCE_MISMATCH error

This PR ensures that previous transaction logic is not executed when is not a payment from the plugin.

Copy link
Collaborator

@Narek13 Narek13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a small suggestion which you can ignore

@InpsydeNiklas InpsydeNiklas added this to the 3.0.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants