Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default UI: Legacy for existing merchants, React for new merchants (4030) #2936

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

Narek13
Copy link
Collaborator

@Narek13 Narek13 commented Dec 19, 2024

Issue Description

Current situation
When the feature flag for the new UI is enabled, all merchants instantly see the new onboarding wizard and settings screens.

Expected

  • When the feature flag is enabled, existing merchants should still get the legacy settings UI, with a new button/toggle to enable the new UI.
    • Those users should not see the onboarding wizard, but directly get the settings pages
  • All new merchants (i.e. fresh installations) should instantly see the new UI, starting with the onboarding wizard.

PR Description

The PR will cover the following scenarios when the feature flag for the new UI is enabled:

  • All the new merchants (i.e. fresh installations) will instantly see the new UI, starting with the onboarding wizard.
  • existing merchants will still get the legacy settings UI, with a new button/toggle to enable the new UI.
    • If onboarded, will not see the onboarding wizard, but directly get the settings pages

@Narek13 Narek13 self-assigned this Dec 19, 2024
Copy link
Collaborator

@danieldudzic danieldudzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Narek13 Looking good!

I have noticed that when I select the "Switch to new settings UI" button, it doesn't do anything, and throws an error in the console:
WooCommerce_settings_‹_WooCommerce_PayPal_Payments_—_WordPress_i_Bring_Me_The_Horizon_-_The_House_of_Wolves_i_a-team__Channel__-_Syde_-_Slack

The page correctly then displays the new settings UI, after a page reload.

The new UI should show up straight after selecting the button.

@Narek13
Copy link
Collaborator Author

Narek13 commented Jan 7, 2025

@danieldudzic I cannot reproduce, works fine for me, once clicked on the button, the page reloads with the new settings. Did you build the scripts? Maybe someone else also can check this. @stracker-phil @Dinamiko

@Narek13 Narek13 requested a review from Dinamiko January 7, 2025 08:50
@danieldudzic
Copy link
Collaborator

@Narek13 Ok, I have now identified the issue. With WP_DEBUG active it was being caused by: #2816

WooCommerce_settings_‹_WooCommerce_PayPal_Payments_—_WordPress_i_pokaż__wp_options_-_AdminerEvo

Copy link
Collaborator

@danieldudzic danieldudzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants