Integration with PHP-Scoper (968) #2993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narek13
requested review from
Dinamiko,
stracker-phil,
danieldudzic,
danielhuesken and
hmouhtar
Biont
reviewed
Jan 16, 2025
Biont
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Really just a small inquiry to add a comment.
On a larger scale, this change begs the question why we're even using PSR contracts - if not to stay compatible with a larger ecosystem.
I know this still allows us to use generic modules internally (and simply not expose a standard API after the build process), but if we have any intention of allowing third-party devs to interface with our code, we might want to consider PsrCompatWrapper objects of some sort. But that's just a remark.
Biont
approved these changes
Jan 16, 2025
Dinamiko
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
We have received some reports about the fatal errors when running the plugin alongside the
psr/logpackage, so we need to use the PHP-Scoper to scope the packagePR Description
The PR will integrate PHP-Scoper with everything excluded except of the
psr/logpackage.