Code Review

README.md

@@ -1 +1,17 @@
-# java-calculator-precourse
+# java-calculator-precourse
+
+구현 할 기능 목록
+1. 문자열을 입력받는 기능
+2. 문자열을 구분자를 기준으로 분리하는 기능
+3. 커스텀 구분자를 지정하는 기능
+4. 잘못된 값을 입력할 경우 예외처리하는 기능
+5. 숫자를 더하는 기능
+6. 결과를 출력하는 기능
+
+
+초기 구현 후 리팩토링 할 목록
+1. 문자열을 구분자를 기준으로 분리하는 기능 -> 기능들을 더 메소드 단위로 나누기
+
+
+예외처리
+1. 잘못된 입력

build.gradle

@@ -18,8 +18,12 @@ repositories {
 
 dependencies {
     implementation 'com.github.woowacourse-projects:mission-utils:1.2.0'
+    testImplementation 'org.mockito:mockito-core:4.11.0'
+    testImplementation 'org.mockito:mockito-inline:4.11.0'
+
 }
 
+
 test {
     useJUnitPlatform()
 }

settings.gradle

@@ -1,4 +1,4 @@
 plugins {
     id 'org.gradle.toolchains.foojay-resolver-convention' version '0.8.0'
 }
-rootProject.name = 'java-calculator'
+rootProject.name = 'java-menu'

src/main/java/menu/Application.java

@@ -0,0 +1,17 @@
+package menu;
+
+import menu.controller.RecommendController;
+import menu.service.RecommendService;
+import menu.view.InputView;
+import menu.view.OutputView;
+
+public class Application {
+    public static void main(String[] args) {
+        RecommendService recommendService = new RecommendService();
+        InputView inputView = new InputView();
+        OutputView outputView = new OutputView();
+
+        RecommendController recommendController = new RecommendController(recommendService, inputView, outputView);
+        recommendController.run();
+    }
+}

src/main/java/menu/controller/RecommendController.java

@@ -0,0 +1,43 @@
+package menu.controller;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import menu.domain.Recommend;
+import menu.service.RecommendService;
+import menu.view.InputView;
+import menu.view.OutputView;
+
+public class RecommendController {
+    private RecommendService recommendService;
+    private InputView inputView;
+    private OutputView outputView;
+    private Recommend recommend;
+
+    public RecommendController(RecommendService recommendService,
+                               InputView inputView,
+                               OutputView outputView) {
+        this.recommendService = recommendService;
+        this.inputView = inputView;
+        this.outputView = outputView;
+    }
+
+    public void run() {
+        outputView.printStart();
+        List<String> coachs = inputView.readCoach();
+        Map<String, List<String>> inedibles = new HashMap<>();
+        Map<String, List<String>> recommendMenus = new HashMap<>();
+        for (String coach : coachs) {
+            List<String> inedible = inputView.readInedible(coach);
+            List<String> recommendMenu = new ArrayList<>();
+            inedibles.put(coach, inedible);
+            recommendMenus.put(coach, recommendMenu);
+        }
+        recommend = new Recommend(coachs, inedibles, recommendMenus);
+        while (recommend.recommendAmount() < 5) {
+            recommendService.recommendMenu(recommend);
+        }
+        outputView.printResult(recommend);
+    }
+}

src/main/java/menu/domain/Category.java

@@ -0,0 +1,47 @@
+package menu.domain;
+
+import camp.nextstep.edu.missionutils.Randoms;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import menu.util.Exception;
+
+public enum Category {
+    일식(1, List.of("규동", "우동", "미소시루", "스시", "가츠동", "오니기리", "하이라이스", "라멘", "오코노미야끼")),
+    한식(2, List.of("김밥", "김치찌개", "쌈밥", "된장찌개", "비빔밥", "칼국수", "불고기", "떡볶이", "제육볶음")),
+    중식(3, List.of("깐풍기", "볶음면", "동파육", "짜장면", "짬뽕", "마파두부", "탕수육", "토마토 달걀볶음", "고추잡채")),
+    아시안(4, List.of("팟타이", "카오 팟", "나시고렝", "파인애플 볶음밥", "쌀국수", "똠얌꿍", "반미", "월남쌈", "분짜")),
+    양식(5, List.of("라자냐", "그라탱", "뇨끼", "끼슈", "프렌치 토스트", "바게트", "스파게티", "피자", "파니니"));
+
+    private int categoryNumber;
+    private List<String> menus;
+
+    Category(int categoryNumber, List<String> menus) {
+        this.categoryNumber = categoryNumber;
+        this.menus = menus;
+    }
+
+    public static String recommendMenu(String category) {
+        List<String> menu = Category.valueOf(category).menus;
+        return Randoms.shuffle(menu).get(0);
+    }
+
+    public static String randomCategory() {
+        int randomNumber = Randoms.pickNumberInRange(1, 5);
+        return Arrays.stream(Category.values())
+                .filter(value -> value.categoryNumber == randomNumber)
+                .map(Category::name)
+                .findFirst()
+                .orElseThrow(() -> new IllegalArgumentException(Exception.ERROR + Exception.RANDOM_NUMBER));
+    }
+
+    public static List<String> getAllMenu() {
+        List<String> allMenu = new ArrayList<>();
+        for (Category value : values()) {
+            for (String menu : value.menus) {
+                allMenu.add(menu);
+            }
+        }
+        return allMenu;
+    }
+}

src/main/java/menu/domain/Recommend.java

@@ -0,0 +1,50 @@
+package menu.domain;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+public class Recommend {
+    private List<String> categories = new ArrayList<>();
+    private List<String> coach;
+    private Map<String, List<String>> inedible;
+    private Map<String, List<String>> recommendMenu;
+
+    public Recommend(List<String> coach, Map<String, List<String>> inedible, Map<String, List<String>> recommendMenu) {
+        this.coach = coach;
+        this.inedible = inedible;
+        this.recommendMenu = recommendMenu;
+    }
+
+    public boolean isCategoryAmountOverThree(String category) {
+        long count = categories.stream().filter(c -> c.equals(category)).count();
+        if (count >= 2) {
+            return true;
+        }
+        return false;
+    }
+
+    public void addCategory(String category) {
+        categories.add(category);
+    }
+
+    public int recommendAmount() {
+        return categories.size();
+    }
+
+    public List<String> getCoach() {
+        return coach;
+    }
+
+    public Map<String, List<String>> getRecommendMenu() {
+        return inedible;
+    }
+
+    public List<String> getCategories() {
+        return categories;
+    }
+
+    public List<String> getRecommendMenu(String coach) {
+        return recommendMenu.get(coach);
+    }
+}

src/main/java/menu/service/RecommendService.java

@@ -0,0 +1,24 @@
+package menu.service;
+
+import menu.domain.Category;
+import menu.domain.Recommend;
+
+public class RecommendService {
+    public void recommendMenu(Recommend recommend) {
+        String category = Category.randomCategory();
+        if (recommend.isCategoryAmountOverThree(category)) {
+            return;
+        }
+        recommend.addCategory(category);
+        for (String coach : recommend.getCoach()) {
+            String menu = null;
+            while (true) {
+                menu = Category.recommendMenu(category);
+                if (!recommend.getRecommendMenu().get(coach).contains(menu)) {
+                    break;
+                }
+            }
+            recommend.getRecommendMenu(coach).add(menu);
+        }
+    }
+}

src/main/java/menu/util/Exception.java

@@ -0,0 +1,9 @@
+package menu.util;
+
+public class Exception {
+    public static final String ERROR = "[ERROR]";
+    public static final String COACH_NAME_LENGTH = "코치의 이름은 최소 2글자, 최대 4글자여야 합니다.";
+    public static final String COACH_AMOUNT = "코치는 최소 2명, 최대 5명까지 식사를 함께 할 수 있습니다.";
+    public static final String RANDOM_NUMBER = "랜덤 숫자가 범위를 벗어났습니다.";
+    public static final String INVALID_INEDIBLE = "유효하지 않는 메뉴입니다.";
+}

src/main/java/menu/util/Parser.java

@@ -0,0 +1,14 @@
+package menu.util;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class Parser {
+    public static List<String> parseInputToList(String[] splitInput) {
+        List<String> list = new ArrayList<>();
+        for (String input : splitInput) {
+            list.add(input);
+        }
+        return list;
+    }
+}

src/main/java/menu/util/Spliter.java

@@ -0,0 +1,7 @@
+package menu.util;
+
+public class Spliter {
+    public static String[] splitInput(String input) {
+        return input.split(",");
+    }
+}

src/main/java/menu/util/Validator.java

@@ -0,0 +1,34 @@
+package menu.util;
+
+import java.util.List;
+import menu.domain.Category;
+
+public class Validator {
+    public static void validateCoach(String[] coachs) {
+        validateNameLength(coachs);
+        validateCoachAmount(coachs);
+    }
+
+    public static void validateNameLength(String[] coachs) {
+        for (String coach : coachs) {
+            if (coach.length() < 2 || coach.length() > 4) {
+                throw new IllegalArgumentException(Exception.ERROR + Exception.COACH_NAME_LENGTH);
+            }
+        }
+    }
+
+    public static void validateCoachAmount(String[] coachs) {
+        if (coachs.length < 2 || coachs.length > 5) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.COACH_AMOUNT);
+        }
+    }
+
+    public static void validateInedible(String[] inedible) {
+        List<String> allMenu = Category.getAllMenu();
+        for (String inedibleMenu : inedible) {
+            if (!allMenu.contains(inedibleMenu)) {
+                throw new IllegalArgumentException(Exception.ERROR + Exception.INVALID_INEDIBLE);
+            }
+        }
+    }
+}

src/main/java/menu/view/InputView.java

@@ -0,0 +1,40 @@
+package menu.view;
+
+import camp.nextstep.edu.missionutils.Console;
+import java.util.List;
+import menu.util.Parser;
+import menu.util.Spliter;
+import menu.util.Validator;
+
+public class InputView {
+    private static final String INPUT_COACH_MSG = "코치의 이름을 입력해 주세요. (, 로 구분)";
+    private static final String INPUT_INEDIBLE = "\n%s(이)가 못 먹는 메뉴를 입력해 주세요.\n";
+
+    public List<String> readCoach() {
+        while (true) {
+            try {
+                System.out.println(INPUT_COACH_MSG);
+                String input = Console.readLine();
+                String[] splitInput = Spliter.splitInput(input);
+                Validator.validateCoach(splitInput);
+                return Parser.parseInputToList(splitInput);
+            } catch (IllegalArgumentException e) {
+                System.out.println(e.getMessage());
+            }
+        }
+    }
+
+    public List<String> readInedible(String name) {
+        while (true) {
+            try {
+                System.out.printf(INPUT_INEDIBLE, name);
+                String input = Console.readLine();
+                String[] splitInput = Spliter.splitInput(input);
+                Validator.validateInedible(splitInput);
+                return Parser.parseInputToList(splitInput);
+            } catch (IllegalArgumentException e) {
+                System.out.println(e.getMessage());
+            }
+        }
+    }
+}

src/main/java/menu/view/OutputView.java

@@ -0,0 +1,37 @@
+package menu.view;
+
+import java.util.List;
+import menu.domain.Recommend;
+
+public class OutputView {
+    private static final String START_MSG = "점심 메뉴 추천을 시작합니다.\n";
+    private static final String RECOMMEND_RESULT = "메뉴 추천 결과입니다.\n";
+    private static final String YOIL = "[ 구분 | 월요일 | 화요일 | 수요일 | 목요일 | 금요일 ]";
+    private static final String CATEGORY_RESULT = "[ 카테고리 | %s | %s | %s | %s | %s ]\n";
+    private static final String COACH_RESULT = "[ %s | %s | %s | %s | %s | %s ]\n";
+    private static final String COMPLETE_RECOMMENDATION = "\n추천을 완료했습니다.";
+
+    public void printStart() {
+        System.out.println(START_MSG);
+    }
+
+    public void printResult(Recommend recommend) {
+        System.out.println(RECOMMEND_RESULT);
+        System.out.println(YOIL);
+        printCategory(recommend);
+        for (String coach : recommend.getCoach()) {
+            printMenu(recommend, coach);
+        }
+        System.out.println(COMPLETE_RECOMMENDATION);
+    }
+
+    private void printCategory(Recommend recommend) {
+        System.out.printf(CATEGORY_RESULT, recommend.getCategories().get(0), recommend.getCategories().get(1),
+                recommend.getCategories().get(2), recommend.getCategories().get(3), recommend.getCategories().get(4));
+    }
+
+    private void printMenu(Recommend recommend, String coach) {
+        List<String> menus = recommend.getRecommendMenu(coach);
+        System.out.printf(COACH_RESULT, coach, menus.get(0), menus.get(1), menus.get(2), menus.get(3), menus.get(4));
+    }
+}