패키지 구조 변경 및 중복 로직 삭제 #796
Merged
패키지 구조 변경 및 중복 로직 삭제 #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgo641
pushed a commit
that referenced
this pull request
Apr 23, 2024
* refactor: 패키지 구조 변경 * feat: useForm hook 구현 * refactor: 중복 로직 리팩토링
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
제가 한게 co-location이라고 부를수 있는건지 확신은 없지만.. 이게 따로 뭐 정확한 기준이 있는건 아니더라구요..?
기능별로 묶고 나머지는 common에 몰아넣었습니다.
type들은 범용적으로 쓰이기 때문에 분리 안하고 common에 두는게 국룰이라고 해서 common에 뒀어요.
저번에 어마어마한 중복을 보여줬던 *Form.ts들에서 중복 로직은 useForm.ts로 분리, 리팩토링 했습니다.
변경 전 패키지 구조______________________________변경 후 패키지 구조
🙋🏻 More