1차 스프린트 리팩토링을 진행한다. #154
Closed
1차 스프린트 리팩토링을 진행한다. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsulocalize
requested changes
Jul 28, 2024
Comment on lines
52
to
53
| public Badge provideBadge(Questionlist questionlist, List<ChecklistQuestion> questions) { | ||
| int categoryScore = calculateCategoryScore(this, questionlist, questions); |
There was a problem hiding this comment.
이부분은 static import를 안쓰는 게 더 좋은 것 같아 보여요!
Comment on lines
19
to
30
| public static int calculateCategoryScore(Category category, Questionlist questionlist, List<ChecklistQuestion> questions) { | ||
| List<ChecklistQuestion> filteredQuestions = questionlist.filterQuestions(category, questions); | ||
|
|
||
| if (filteredQuestions.isEmpty()) { | ||
| return 0; | ||
| } | ||
|
|
||
| int maxScore = Grade.calculateMaxScore(filteredQuestions.size()); | ||
| int totalScore = Grade.calculateTotalScore(filteredQuestions); | ||
|
|
||
| return totalScore * 10 / maxScore; | ||
| } |
There was a problem hiding this comment.
점수 계산하는 두 메서드에서 중복을 제거할 수 있을 것 같아 보여요
| @@ -109,8 +114,8 @@ private void createChecklistQuestions(ChecklistCreateRequest checklistCreateRequ | |||
| List<QuestionCreateRequest> questions = checklistCreateRequest.questions(); | |||
| validateQuestion(questions); | |||
| for (QuestionCreateRequest questionCreateRequest : questions) { | |||
| Integer questionId = questionCreateRequest.questionId(); | |||
| ChecklistQuestion checklistQuestion = new ChecklistQuestion(checklist, questionId, | |||
| Question question = questionList.findById(questionCreateRequest.questionId()); | |||
There was a problem hiding this comment.
메서드 내에서 사용되는 부분이 없어 보입니다
tkdgur0906
requested changes
Jul 28, 2024
| import com.bang_ggood.category.domain.Category; | ||
| import java.util.List; | ||
|
|
||
| public class ChecklistScore { |
There was a problem hiding this comment.
점수에 대한 로직을 다른 도메인으로 분리하는 것은 좋은 것 같네요!
| .mapToInt(CategoryScoreReadResponse::score) | ||
| .sum() / categoryScores.size(); | ||
| private int getChecklistScore(Checklist checklist) { | ||
| return calculateTotalScore(checklist.getQuestions()); |
There was a problem hiding this comment.
static import를 사용하지 않는 것이 더 명확할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타